Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ipv6 outputs #10275

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

ehorning
Copy link
Contributor

@ehorning ehorning commented Mar 25, 2024

Add Ipv6 outputs to interconnect attachment resource. Fixes hashicorp/terraform-provider-google#17671.

Followup to #9890

Release Note Template for Downstream PRs (will be copied)

compute: added `cloud_router_ipv6_address`, `customer_router_ipv6_address` fields to `google_compute_interconnect_attachment` resource

@github-actions github-actions bot requested a review from rileykarson March 25, 2024 15:50
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@ehorning
Copy link
Contributor Author

I'm not sure why the lint check is failing here -- yamllint seems to run through fine when I run it against this file locally

@rileykarson
Copy link
Member

@trodge any idea what's up w/ the linter? Seems to be a missing dependency.

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 34 insertions(+))
google-beta provider: Diff ( 2 files changed, 34 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 891
Passed tests: 819
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- the lint issue appears to be resolved in #10269, so post-merge shouldn't cause an issue.

@rileykarson rileykarson merged commit db62daf into GoogleCloudPlatform:main Mar 26, 2024
14 of 16 checks passed
@ehorning ehorning deleted the add-ipv6-outputs branch March 26, 2024 21:13
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 27, 2024
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IPv6 address outputs
3 participants