Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move container building to a YAML file and specify a service account #9694

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Move container building to a YAML file and specify a service account #9694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .ci/gcb-build-container.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
# substitutions:
# _IMAGE_NAME: 'gcr.io/graphite-docker-images/bash-plus:latest'
# _DIRECTORY: '.ci/containers/bash-plus'

steps:
- name: 'gcr.io/cloud-builders/docker'
args: ['build', '-t', '$_IMAGE_NAME', '.']
dir: '$_DIRECTORY'

images:
- '$_IMAGE_NAME'
Copy link
Member

@shuyama1 shuyama1 Dec 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are we getting this value? like substitutions from the GCB trigger?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, found the bash-plus-test trigger. Oh, I see, so we're gonna have separate triggers for each container but share the building yaml file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep !.. Substitutions are in the trigger UI


logsBucket: 'gs://cloudbuild-container-builder-logs'