Move container building to a YAML file and specify a service account #9694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
shuyama1
reviewed
Dec 22, 2023
| dir: '$_DIRECTORY' | ||
|
|
||
| images: | ||
| - '$_IMAGE_NAME' |
There was a problem hiding this comment.
where are we getting this value? like substitutions from the GCB trigger?
There was a problem hiding this comment.
okay, found the bash-plus-test trigger. Oh, I see, so we're gonna have separate triggers for each container but share the building yaml file?
There was a problem hiding this comment.
Yep !.. Substitutions are in the trigger UI
shuyama1
approved these changes
Dec 22, 2023
kapreus
pushed a commit
to kapreus/magic-modules
that referenced
this pull request
Jan 2, 2024
kylase
pushed a commit
to yuanchuankee/magic-modules
that referenced
this pull request
Jan 21, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart of the security improvements to our continuous integration system.
We are moving these operations to a YAML file and specifying a bucket that the logs can be written to :)
Release Note Template for Downstream PRs (will be copied)