Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added google_scc_organization_custom_module #9081

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Added google_scc_organization_custom_module #9081

merged 3 commits into from
Sep 26, 2023

Conversation

melinath
Copy link
Member

@melinath melinath commented Sep 25, 2023

Part 3 of b/296259216 - completes the ticket.

Release Note Template for Downstream PRs (will be copied)

`google_scc_organization_custom_module`

@melinath melinath requested review from a team and shuyama1 and removed request for a team September 25, 2023 22:52
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 1836 insertions(+), 417 deletions(-))
Terraform Beta: Diff ( 10 files changed, 1836 insertions(+), 417 deletions(-))
TF Conversion: Diff ( 1 file changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3089
Passed tests 2787
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSecurityCenterFolderCustomModule|TestAccSecurityCenterProjectCustomModule|TestAccSecurityCenterOrganizationCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterFolderCustomModule[Debug log]
TestAccSecurityCenterProjectCustomModule[Debug log]
TestAccSecurityCenterOrganizationCustomModule[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 1926 insertions(+), 509 deletions(-))
Terraform Beta: Diff ( 11 files changed, 1926 insertions(+), 509 deletions(-))
TF Conversion: Diff ( 1 file changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3089
Passed tests 2789
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants