Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for project-level custom modules #8993

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Added support for project-level custom modules #8993

merged 5 commits into from
Sep 19, 2023

Conversation

melinath
Copy link
Member

Related to b/296259216. Subsequent PRs will add support for folder-level and org-level custom modules.

Release Note Template for Downstream PRs (will be copied)

`google_scc_project_custom_module`

@melinath melinath requested review from a team and trodge and removed request for a team September 18, 2023 22:24
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1654 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1654 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 338 insertions(+))
TF OiCS: Diff ( 8 files changed, 250 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1655 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1655 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 338 insertions(+))
TF OiCS: Diff ( 8 files changed, 250 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3072
Passed tests 2770
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleUpdate|TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleFullExample|TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleUpdate[Debug log]
TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@melinath
Copy link
Member Author

melinath commented Sep 19, 2023

It looks like custom modules can't be created / modified concurrently. I don't see it documented anywhere, but it should be scoped to a particular parent.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1676 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1676 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 338 insertions(+))
TF OiCS: Diff ( 8 files changed, 250 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3072
Passed tests 2771
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy|TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@melinath melinath merged commit e9e03ec into main Sep 19, 2023
@melinath melinath deleted the b-296259216 branch September 19, 2023 21:58
bobyu-google pushed a commit to bobyu-google/magic-modules that referenced this pull request Sep 20, 2023
)

* Added support for project-level custom modules

Related to b/296259216

* gofmt

* Added client-side validation of display_name

* Fixed expressions in update test

* Added mutex
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
)

* Added support for project-level custom modules

Related to b/296259216

* gofmt

* Added client-side validation of display_name

* Fixed expressions in update test

* Added mutex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants