-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for project-level custom modules #8993
Conversation
Related to b/296259216
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1654 insertions(+), 2 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1655 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleUpdate|TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleFullExample|TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleBasicExample |
Rerun these tests in REPLAYING mode to catch issues
|
It looks like custom modules can't be created / modified concurrently. I don't see it documented anywhere, but it should be scoped to a particular parent. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1676 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocJobIamPolicy|TestAccSecurityCenterProjectCustomModule_sccProjectCustomModuleFullExample |
Rerun these tests in REPLAYING mode to catch issues
|
Related to b/296259216. Subsequent PRs will add support for folder-level and org-level custom modules.
Release Note Template for Downstream PRs (will be copied)