Removed the automatic field from the google_secret_manager_secret resource

[abheda-crest]

Removed the automatic field from the google_secret_manager_secret resource.

Release Note Template for Downstream PRs (will be copied)

secretmanager: removed `automatic` field in `google_secret_manager_secret` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[abheda-crest]

This PR depends on the existing PR to be merged.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field replication.automatic within resource google_secret_manager_secret was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 26 files changed, 404 insertions(+), 59 deletions(-))
Terraform Beta: Diff ( 30 files changed, 409 insertions(+), 64 deletions(-))
TF Conversion: Diff ( 1 file changed, 45 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 16 files changed, 134 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3010
Passed tests 2691
Skipped tests: 302
Affected tests: 17

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_webhook_config|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample|TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_secretWithAutomaticCmekExample|TestAccSecretManagerSecret_secretConfigBasicExample|TestAccSecretManagerSecret_import|TestAccSecretManagerSecretIamMemberGenerated|TestAccSecretManagerSecret_versionAliasesUpdate|TestAccSecretManagerSecretIamBindingGenerated|TestAccDataSourceSecretManagerSecret_basic|TestAccSecretManagerSecretIamPolicyGenerated|TestAccSecretManagerSecret_userManagedCmekUpdate|TestAccSecretManagerSecret_cmek

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudBuildTrigger_webhook_config[Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample[Debug log]
TestAccCloudFunctionsFunction_secretMount[Debug log]
TestAccCloudFunctionsFunction_secretEnvVar[Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretVolumeExample[Debug log]
TestAccCloudfunctions2function_cloudfunctions2SecretEnvExample[Debug log]
TestAccSecretManagerSecret_automaticCmekUpdate[Debug log]
TestAccSecretManagerSecret_secretWithAutomaticCmekExample[Debug log]
TestAccSecretManagerSecret_secretConfigBasicExample[Debug log]
TestAccSecretManagerSecret_import[Debug log]
TestAccSecretManagerSecretIamMemberGenerated[Debug log]
TestAccSecretManagerSecret_versionAliasesUpdate[Debug log]
TestAccSecretManagerSecretIamBindingGenerated[Debug log]
TestAccDataSourceSecretManagerSecret_basic[Debug log]
TestAccSecretManagerSecretIamPolicyGenerated[Debug log]
TestAccSecretManagerSecret_userManagedCmekUpdate[Debug log]
TestAccSecretManagerSecret_cmek[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[c2thorn]

Hi @abheda-crest,
This looks good on initial review. I understand that this also includes changes from #8838 that were just recently merged. I would like to wait for the feature branch to sync with main which should happen in the first half of this week before merging.

In the meantime, is there already an upgrade guide entry explaining the removal of automatic in favor of auto? If not, please refer to these steps:

https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#add-upgrade-guide-entries-to-the-main-branch-of-magic-modules

[abheda-crest]

Hi @abheda-crest, This looks good on initial review. I understand that this also includes changes from #8838 that were just recently merged. I would like to wait for the feature branch to sync with main which should happen in the first half of this week before merging.

Yeah, I agree with you.

In the meantime, is there already an upgrade guide entry explaining the removal of automatic in favor of auto? If not, please refer to these steps:

https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#add-upgrade-guide-entries-to-the-main-branch-of-magic-modules

I've updated the PR for the upgrade guide entry for the removal of the automatic field.

[c2thorn]

Thanks @abheda-crest. Soft LGTM for now. I will perform the branch sync tomorrow, then check this PR one more time. If it looks good, I will approve then merge both PR's.

[abheda-crest]

Thanks @abheda-crest. Soft LGTM for now. I will perform the branch sync tomorrow, then check this PR one more time. If it looks good, I will approve then merge both PR's.

@c2thorn I've pulled the changes from FEATURE-BRANCH-major-release-5.0.0 and resolved the merge conflicts. This PR is now ready.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field replication.automatic within resource google_secret_manager_secret was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 9 insertions(+), 98 deletions(-))
Terraform Beta: Diff ( 3 files changed, 9 insertions(+), 93 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 24 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3036
Passed tests 2730
Skipped tests: 304
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample|TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample[Debug log]
TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test