Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for auto and deprecated automatic field in google_secret_manager_secret resource #8838

Conversation

abheda-crest
Copy link
Contributor

@abheda-crest abheda-crest commented Sep 1, 2023

Added support for the auto field and deprecated automatic field in the google_secret_manager_secret resource
fixes hashicorp/terraform-provider-google#10679
fixes hashicorp/terraform-provider-google#9272
fixes hashicorp/terraform-provider-google#14282

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

secretmanager: added `auto` field to `google_secret_manager_secret` resource
secretmanager: deprecated `automatic` field on `google_secret_manager_secret`. Use `auto` instead.

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 1, 2023
@abheda-crest
Copy link
Contributor Author

This PR follows the approach suggested by @slevenick in his comment.

@abheda-crest abheda-crest marked this pull request as draft September 1, 2023 07:10
@abheda-crest abheda-crest marked this pull request as ready for review September 1, 2023 08:37
@abheda-crest
Copy link
Contributor Author

@SarahFrench Could you please start the tests as it is awaiting your approval and review this PR?

@abheda-crest abheda-crest changed the title Added support for automatic_replication and deprecated automatic field in google_secret_manager_secret resource Added support for auto and deprecated automatic field in google_secret_manager_secret resource Sep 4, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 4, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 26 files changed, 438 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 30 files changed, 443 insertions(+), 55 deletions(-))
TF Conversion: Diff ( 1 file changed, 63 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 16 files changed, 134 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3010
Passed tests 2711
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountJwt|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_secretWithAutomaticCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccSecretManagerSecret_automaticCmekUpdate[Debug log]
TestAccSecretManagerSecret_secretWithAutomaticCmekExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@abheda-crest
Copy link
Contributor Author

@SarahFrench Could you please review this PR?

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I've caught up on context needed to review this PR. As this PR is trying to avoid breaking changes, could you please update this handwritten acceptance test to show that an old config that still uses automatic = true still works as expected?

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 6, 2023
@abheda-crest
Copy link
Contributor Author

abheda-crest commented Sep 6, 2023

👋 I've caught up on context needed to review this PR. As this PR is trying to avoid breaking changes, could you please update this handwritten acceptance test to show that an old config that still uses automatic = true still works as expected?

I've added a test case that covers the automatic = true. Just to clarify, while importing the secret resources having the old field automatic = true, the imported resource will have the new field auto as an empty object instead and the automatic field will be false. Hence, I've kept replication.0.auto and replication.0.automatic in ImportStateVerifyIgnore.

@abheda-crest
Copy link
Contributor Author

@SarahFrench Could you please start the tests and review the changes?

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 8, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 26 files changed, 479 insertions(+), 50 deletions(-))
Terraform Beta: Diff ( 30 files changed, 484 insertions(+), 55 deletions(-))
TF Conversion: Diff ( 1 file changed, 63 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 16 files changed, 134 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3020
Passed tests 2722
Skipped tests: 297
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSecretManagerSecret_automaticCmekUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecretManagerSecret_automaticCmekUpdate[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@SarahFrench SarahFrench merged commit 1e2b51e into GoogleCloudPlatform:main Sep 11, 2023
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
…secret_manager_secret` resource (GoogleCloudPlatform#8838)

* Added support for automatic_replication field in google_secret_manager_secret resource

* Replaced deprecated field automatic with automatic_replication in terraform configs

* Improved the deprecation_message

* Changed the name of field from automatic_replication to auto

* Adjusted white spaces

* Added test case to cover the automatic field
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…secret_manager_secret` resource (GoogleCloudPlatform#8838)

* Added support for automatic_replication field in google_secret_manager_secret resource

* Replaced deprecated field automatic with automatic_replication in terraform configs

* Improved the deprecation_message

* Changed the name of field from automatic_replication to auto

* Adjusted white spaces

* Added test case to cover the automatic field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants