-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for auto
and deprecated automatic
field in google_secret_manager_secret
resource
#8838
Added support for auto
and deprecated automatic
field in google_secret_manager_secret
resource
#8838
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This PR follows the approach suggested by @slevenick in his comment. |
@SarahFrench Could you please start the tests as it is awaiting your approval and review this PR? |
…t-manager-add-automatic-replication
automatic_replication
and deprecated automatic
field in google_secret_manager_secret
resourceauto
and deprecated automatic
field in google_secret_manager_secret
resource
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 26 files changed, 438 insertions(+), 50 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountJwt|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_secretWithAutomaticCmekExample |
Rerun these tests in REPLAYING mode to catch issues
|
@SarahFrench Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 I've caught up on context needed to review this PR. As this PR is trying to avoid breaking changes, could you please update this handwritten acceptance test to show that an old config that still uses automatic = true
still works as expected?
…t-manager-add-automatic-replication
I've added a test case that covers the |
@SarahFrench Could you please start the tests and review the changes? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 26 files changed, 479 insertions(+), 50 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSecretManagerSecret_automaticCmekUpdate |
Rerun these tests in REPLAYING mode to catch issues
|
…secret_manager_secret` resource (GoogleCloudPlatform#8838) * Added support for automatic_replication field in google_secret_manager_secret resource * Replaced deprecated field automatic with automatic_replication in terraform configs * Improved the deprecation_message * Changed the name of field from automatic_replication to auto * Adjusted white spaces * Added test case to cover the automatic field
…secret_manager_secret` resource (GoogleCloudPlatform#8838) * Added support for automatic_replication field in google_secret_manager_secret resource * Replaced deprecated field automatic with automatic_replication in terraform configs * Improved the deprecation_message * Changed the name of field from automatic_replication to auto * Adjusted white spaces * Added test case to cover the automatic field
Added support for the
auto
field and deprecatedautomatic
field in thegoogle_secret_manager_secret
resourcefixes hashicorp/terraform-provider-google#10679
fixes hashicorp/terraform-provider-google#9272
fixes hashicorp/terraform-provider-google#14282
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)