-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: honor upstream default for enableDynamicPortAllocation #6125
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons |
in the |
Having a hardcoded default_value of `false` for the `enableDynamicPortAllocation` property is troublesome, and the upstream default should be used. This was added as part of GoogleCloudPlatform#6022. By hardcoding the default here, any client will explicitly deprogram the dynamic port allocation setting if it is not part of the client configuration. This is causing problems for those clients that have enabled the dynamic port allocation out of band, since the current support is incomplete (not all parameters can be set via Terraform: terraform-google-modules/terraform-google-cloud-nat#64 (comment)). While full support is being added, removing hardcoded defaults allow out-of-band configurations to continue working.
Sure! Done. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons |
Having a hardcoded default_value of
false
for theenableDynamicPortAllocation
property is troublesome, and theupstream default should be used. This was added as part of #6022.
By hardcoding the default here, any client will explicitly deprogram
the dynamic port allocation setting if it is not part of the client
configuration. This is causing problems for those clients that have
enabled the dynamic port allocation out of band, since the current
support is incomplete (not all parameters can be set via Terraform:
terraform-google-modules/terraform-google-cloud-nat#64 (comment)). While
full support is being added, removing hardcoded defaults allow
out-of-band configurations to continue working.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)