-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DynamicPortAllocation for Cloud NAT #6022
Add DynamicPortAllocation for Cloud NAT #6022
Conversation
Signed-off-by: Trung <[email protected]>
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 44 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ichbinfrog
Can you add an example of of this field in use or add it to an existing example? That way it will be tested for functionality.
Signed-off-by: Trung <[email protected]>
Thanks for the review @c2thorn. Sorry if it's not the correct method but I've added in the latest commit tests for the different port allocation methods in |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 61 insertions(+), 12 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRouterNat_withPortAllocationMethods|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample |
Having a hardcoded default_value of `false` for the `enableDynamicPortAllocation` property is troublesome, and the upstream default should be used. This was added as part of GoogleCloudPlatform#6022. By hardcoding the default here, any client will explicitly deprogram the dynamic port allocation setting if it is not part of the client configuration. This is causing problems for those clients that have enabled the dynamic port allocation out of band, since the current support is incomplete (not all parameters can be set via Terraform: terraform-google-modules/terraform-google-cloud-nat#64 (comment)). While full support is being added, removing hardcoded defaults allow out-of-band configurations to continue working.
…amicPortAllocation Support for the Dynamic Port Allocation feature (tracked in terraform-google-modules/terraform-google-cloud-nat#64 and hashicorp/terraform-provider-google#11052) was initially implemented in GoogleCloudPlatform#6022, but it lacked support for the maxPortsPerVm field. This field is crucial to allow the full configuration to work.
…amicPortAllocation (#6155) Support for the Dynamic Port Allocation feature (tracked in terraform-google-modules/terraform-google-cloud-nat#64 and hashicorp/terraform-provider-google#11052) was initially implemented in #6022, but it lacked support for the maxPortsPerVm field. This field is crucial to allow the full configuration to work.
Adds the
enable_dynamic_port_allocation
(see equivalent onenableDynamicPortAllocation
field in the respective API) field for thegoogle_compute_router_nat
resource.Solves this issue: hashicorp/terraform-provider-google#11052
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)