Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about branch out of date message to PR template #586

Merged
merged 12 commits into from
Oct 23, 2018

Conversation

rileykarson
Copy link
Member

This can be a little confusing and happens basically immediately to PRs! Let's reassure contributors that the message is fine so they don't waste their time.


[all]

[terraform]

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs a re-run since it doesn't have terraform-beta in it yet, but it looks good to me.

@nat-henderson
Copy link
Contributor

Or, heck, looks like the old Magician got it - never mind, all's well, merge when ready.

@modular-magician modular-magician merged commit f7a4e00 into master Oct 23, 2018
@rileykarson rileykarson deleted the rileykarson-patch-1 branch December 21, 2018 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants