Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singular initialize method #591

Merged
merged 5 commits into from
Oct 22, 2018
Merged

Add singular initialize method #591

merged 5 commits into from
Oct 22, 2018

Conversation

slevenick
Copy link
Contributor

Add an initialize and fetch_resource method for singular inspec resources. This uses a train plugin that will need to be installed by the user.


[all]

[terraform]

[terraform-beta]

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

[inspec]

Add initialize and fetch methods for singular inspec resources

end
<% else # object.self_link_query.nil? -%>
# TODO(slevenick) for other products
def initialize(params)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: another initialize method will be needed here to support other products (SQL in particular) but I don't want to add the code here before it will be used to generate anything.

Copy link
Contributor

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We chatted over my one concern (the .fetch method), but it's good with me.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#2302

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit f3ab9c8) have been included in your existing downstream PRs.

@modular-magician modular-magician merged commit 01f33c8 into master Oct 22, 2018
@slevenick slevenick deleted the inspec-initialize branch April 15, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants