Add Secret Manager Secret Data Source #4815

upodroid · 2021-05-26T21:20:39Z

Fixes: hashicorp/terraform-provider-google#9202

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_secret_manager_secret`

modular-magician · 2021-05-26T21:22:03Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

modular-magician · 2021-05-26T21:30:41Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))

modular-magician · 2021-05-26T21:31:01Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=189292"

modular-magician · 2021-05-26T21:31:03Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))

modular-magician · 2021-05-26T21:31:24Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=189292"

modular-magician · 2021-05-26T21:49:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))

modular-magician · 2021-05-26T21:50:00Z

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=189294"

modular-magician · 2021-05-26T23:18:24Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSecretManagerSecret_basic|TestAccBigQueryDataTable_bigtable You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=189296"

modular-magician · 2021-05-26T23:24:01Z

Tests failed during RECORDING mode: TestAccDataSourceSecretManagerSecret_basic Please fix these to complete your PR

c2thorn

Going over PR's I missed. This needs a rebase as well

mmv1/third_party/terraform/website/docs/d/secret_manager_secret.html.markdown

c2thorn · 2021-07-08T16:02:04Z

mmv1/third_party/terraform/tests/data_source_secret_manager_secret_test.go

+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccDataSourceSecretManagerSecret_basic(t *testing.T) {


This test failed with a no "id" found in attributes error

Is it similar to this? #4515 (comment)

modular-magician · 2021-07-08T16:32:08Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 7 files changed, 121 insertions(+), 165 deletions(-))

modular-magician · 2021-07-08T16:33:19Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))

c2thorn · 2021-07-08T17:09:27Z

/gcbrun

modular-magician · 2021-07-08T17:20:30Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 120 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 7 files changed, 121 insertions(+), 165 deletions(-))

modular-magician · 2021-07-08T18:42:53Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSecretManagerSecret_basic|TestAccContainerNodePool_withGPU You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=195678

modular-magician · 2021-07-08T19:02:33Z

Tests failed during RECORDING mode: TestAccDataSourceSecretManagerSecret_basic|TestAccContainerNodePool_withGPU Please fix these to complete your PR

upodroid · 2021-08-05T19:25:26Z

bump

c2thorn · 2021-08-10T20:24:20Z

mmv1/third_party/terraform/data_sources/data_source_secret_manager_secret.go

+}
+
+func dataSourceSecretManagerSecretRead(d *schema.ResourceData, meta interface{}) error {
+


Had some time to look into this, and realized that this function doesn't set an ID for the datasource. This should address the test failure from before.

This is fixed now.

mmv1/third_party/terraform/tests/data_source_secret_manager_secret_test.go

modular-magician · 2021-08-10T21:25:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 97 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 7 files changed, 98 insertions(+), 165 deletions(-))

modular-magician · 2021-08-10T21:26:54Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 125 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 6 files changed, 125 insertions(+), 164 deletions(-))

c2thorn · 2021-08-10T21:43:50Z

/gcbrun

modular-magician · 2021-08-10T21:44:19Z

Error trying to cancel build ()

modular-magician · 2021-08-10T21:44:20Z

Error trying to cancel build ()

modular-magician · 2021-08-10T21:44:21Z

Error trying to cancel build ()

modular-magician · 2021-08-10T21:54:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 125 insertions(+), 164 deletions(-))
Terraform Beta: Diff ( 7 files changed, 126 insertions(+), 165 deletions(-))

c2thorn · 2021-08-11T15:01:12Z

/gcbrun

modular-magician · 2021-08-11T15:01:44Z

Error trying to cancel build ()

modular-magician · 2021-08-11T15:01:45Z

Error trying to cancel build ()

modular-magician · 2021-08-23T16:00:56Z

Error trying to cancel build ()

modular-magician · 2021-08-23T16:00:56Z

Error trying to cancel build ()

modular-magician · 2021-08-23T16:00:57Z

Error trying to cancel build ()

modular-magician · 2021-08-23T16:00:58Z

Error trying to cancel build ()

modular-magician · 2021-08-23T16:11:17Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 125 insertions(+), 165 deletions(-))
Terraform Beta: Diff ( 6 files changed, 125 insertions(+), 165 deletions(-))

Co-authored-by: upodroid <[email protected]>

modular-magician · 2021-08-30T16:38:46Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 125 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 6 files changed, 125 insertions(+), 167 deletions(-))

c2thorn · 2021-08-30T16:54:48Z

/gcbrun

modular-magician · 2021-08-30T17:06:16Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 125 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 9 files changed, 128 insertions(+), 173 deletions(-))

c2thorn · 2021-08-30T21:33:47Z

/gcbrun

modular-magician · 2021-08-30T21:44:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 125 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 6 files changed, 125 insertions(+), 167 deletions(-))

c2thorn · 2021-08-31T20:19:15Z

/gcbrun

modular-magician · 2021-08-31T20:29:31Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 125 insertions(+), 167 deletions(-))
Terraform Beta: Diff ( 7 files changed, 126 insertions(+), 168 deletions(-))

upodroid · 2021-08-31T21:00:56Z

Is it me or is the CI a bit wobbly this month?

c2thorn · 2021-08-31T21:24:43Z

@upodroid we made a lot of changes at the beginning of the month in attempts to improve things but also broke a few things along the way... Most of them should be fixed, but for this PR I'm having issues with the VCR build that I haven't seen in anywhere else.

modular-magician · 2021-08-31T22:11:44Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSecretManagerSecret_basic|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_withDisabledIndependentEndpointMapping|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=203673

Co-authored-by: upodroid <[email protected]> Co-authored-by: Cameron Thornton <[email protected]>

google-cla bot added the cla: yes label May 26, 2021

modular-magician requested a review from c2thorn May 26, 2021 21:22

c2thorn requested changes Jul 8, 2021

View reviewed changes

c2thorn requested changes Aug 10, 2021

View reviewed changes

c2thorn and others added 7 commits August 30, 2021 10:55

Fix TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample

b5ca3b9

add secret manager secret datasource

1697c42

Co-authored-by: upodroid <[email protected]>

fix typos

fb48fb0

fix typo in test

a2f90f2

fix typo

bcc3b66

add id to read function

c5a5a03

fix bad copy paste

2266b94

c2thorn force-pushed the secret-manager-secret-ds branch from ebd1616 to 2266b94 Compare August 30, 2021 16:27

c2thorn approved these changes Sep 2, 2021

View reviewed changes

c2thorn merged commit 82bf899 into GoogleCloudPlatform:master Sep 2, 2021

c2thorn deleted the secret-manager-secret-ds branch September 2, 2021 15:59

This was referenced Sep 2, 2021

Add Secret Manager Secret Data Source hashicorp/terraform-provider-google-beta#3588

Merged

Add Secret Manager Secret Data Source hashicorp/terraform-provider-google#9983

Merged

khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021

Add Secret Manager Secret Data Source (GoogleCloudPlatform#4815)

4f2a3a8

Co-authored-by: upodroid <[email protected]> Co-authored-by: Cameron Thornton <[email protected]>

		}

		func dataSourceSecretManagerSecretRead(d *schema.ResourceData, meta interface{}) error {

Add Secret Manager Secret Data Source #4815

Add Secret Manager Secret Data Source #4815

Conversation

upodroid commented May 26, 2021

modular-magician commented May 26, 2021

modular-magician commented May 26, 2021

Diff report:

modular-magician commented May 26, 2021

modular-magician commented May 26, 2021

Diff report:

modular-magician commented May 26, 2021

modular-magician commented May 26, 2021

Diff report:

modular-magician commented May 26, 2021

modular-magician commented May 26, 2021

modular-magician commented May 26, 2021

c2thorn left a comment

Choose a reason for hiding this comment

c2thorn Jul 8, 2021

Choose a reason for hiding this comment

upodroid Jul 8, 2021

Choose a reason for hiding this comment

modular-magician commented Jul 8, 2021

Diff report:

modular-magician commented Jul 8, 2021

Diff report:

c2thorn commented Jul 8, 2021

modular-magician commented Jul 8, 2021

Diff report:

modular-magician commented Jul 8, 2021

modular-magician commented Jul 8, 2021

upodroid commented Aug 5, 2021

c2thorn Aug 10, 2021

Choose a reason for hiding this comment

upodroid Aug 10, 2021

Choose a reason for hiding this comment

modular-magician commented Aug 10, 2021

Diff report:

modular-magician commented Aug 10, 2021

Diff report:

c2thorn commented Aug 10, 2021

modular-magician commented Aug 10, 2021

modular-magician commented Aug 10, 2021

modular-magician commented Aug 10, 2021

modular-magician commented Aug 10, 2021

Diff report:

c2thorn commented Aug 11, 2021

modular-magician commented Aug 11, 2021

modular-magician commented Aug 11, 2021

modular-magician commented Aug 23, 2021

modular-magician commented Aug 23, 2021

modular-magician commented Aug 23, 2021

modular-magician commented Aug 23, 2021

modular-magician commented Aug 23, 2021

Diff report:

modular-magician commented Aug 30, 2021

Diff report:

c2thorn commented Aug 30, 2021

modular-magician commented Aug 30, 2021

Diff report:

c2thorn commented Aug 30, 2021

modular-magician commented Aug 30, 2021

Diff report:

c2thorn commented Aug 31, 2021

modular-magician commented Aug 31, 2021

Diff report:

upodroid commented Aug 31, 2021

c2thorn commented Aug 31, 2021

modular-magician commented Aug 31, 2021