-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google HC Datasource #4515
Add Google HC Datasource #4515
Conversation
Fork Update
Co-authored-by: upodroid <[email protected]>
Co-authored-by: upodroid <[email protected]>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
I'm getting a weird error in the test. The error is present in both
|
/gcbrun Are you running the tests with a new version of Terraform core? I believe that 0.14.x causes some issues in datasource tests specifically, so we still run the CI tests on 0.13 or 0.12. I'd recommend having an alternate version of TF core to be able to run these sorts of tests |
/gcbrun |
Ah, Cameron mentioned something about this. I forgot |
Bump |
/gcbrun Sorry I've taken so long to review! |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177914" |
This seems good to me. Assuming tests pass I'll merge |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177914" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeHealthCheckDatasource_basic|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccAccessContextManager|TestAccComposerEnvironment_withEncryptionConfig|TestAccNotebooksInstance_notebookInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177931" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passes, thanks for the addition!
Fixes: hashicorp/terraform-provider-google#8429
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)