Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google HC Datasource #4515

Merged
merged 15 commits into from
Mar 18, 2021
Merged

Conversation

upodroid
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#8429

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_health_check`

@google-cla google-cla bot added the cla: yes label Feb 19, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@upodroid
Copy link
Contributor Author

upodroid commented Feb 19, 2021

I'm getting a weird error in the test.

The error is present in both TestAccComputeHealthCheckDatasource_basic and TestAccDataSourceComputeBackendService_basic

-----------------------------------------------------
2021/02/19 21:57:05 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/02/19 21:57:05 [DEBUG] Retry Transport: Returning after 1 attempts
    testing_new_config.go:96: no "id" found in attributes
    testing_new.go:49: no "id" found in attributes
--- FAIL: TestAccComputeHealthCheckDatasource_basic (29.44s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google-beta/v3/google-beta	31.702s
FAIL
2021/02/19 21:49:45 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/02/19 21:49:45 [DEBUG] Retry Transport: Returning after 1 attempts
    testing_new_config.go:96: no "id" found in attributes
    testing_new.go:49: no "id" found in attributes
--- FAIL: TestAccDataSourceComputeBackendService_basic (41.08s)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 121 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 6 files changed, 121 insertions(+), 19 deletions(-))

@slevenick
Copy link
Contributor

I'm getting a weird error in the test.

The error is present in both TestAccComputeHealthCheckDatasource_basic and TestAccDataSourceComputeBackendService_basic

-----------------------------------------------------
2021/02/19 21:57:05 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/02/19 21:57:05 [DEBUG] Retry Transport: Returning after 1 attempts
    testing_new_config.go:96: no "id" found in attributes
    testing_new.go:49: no "id" found in attributes
--- FAIL: TestAccComputeHealthCheckDatasource_basic (29.44s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google-beta/v3/google-beta	31.702s
FAIL
2021/02/19 21:49:45 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/02/19 21:49:45 [DEBUG] Retry Transport: Returning after 1 attempts
    testing_new_config.go:96: no "id" found in attributes
    testing_new.go:49: no "id" found in attributes
--- FAIL: TestAccDataSourceComputeBackendService_basic (41.08s)

/gcbrun

Are you running the tests with a new version of Terraform core? I believe that 0.14.x causes some issues in datasource tests specifically, so we still run the CI tests on 0.13 or 0.12. I'd recommend having an alternate version of TF core to be able to run these sorts of tests

@slevenick
Copy link
Contributor

/gcbrun

@upodroid
Copy link
Contributor Author

Ah, Cameron mentioned something about this. I forgot

@upodroid
Copy link
Contributor Author

Bump

@slevenick
Copy link
Contributor

/gcbrun

Sorry I've taken so long to review!

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177914"

@slevenick
Copy link
Contributor

This seems good to me. Assuming tests pass I'll merge

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 121 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 6 files changed, 121 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177914"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeHealthCheckDatasource_basic|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccAccessContextManager|TestAccComposerEnvironment_withEncryptionConfig|TestAccNotebooksInstance_notebookInstanceFullExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177931"

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes, thanks for the addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for google_compute_health_check
3 participants