Promote field compute_instance.scheduling.min_node_cpus and related fields to ga

[ScottSuarez]

closes hashicorp/terraform-provider-google#8583

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: promoted field `server_binding` and `cpu_overcommit_type` fields on `google_node_template` to ga
compute: promoted field `scheduling.min_node_cpus` field on `google_compute_instance` to ga
compute: documented field `scheduling.min_node_cpus` field on `google_compute_instance`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177353"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 19 files changed, 206 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 19 files changed, 45 insertions(+), 37 deletions(-))
Ansible: Diff ( 10 files changed, 151 insertions(+), 47 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
Inspec: Diff ( 7 files changed, 14 insertions(+), 14 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177355"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 19 files changed, 208 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 22 files changed, 47 insertions(+), 40 deletions(-))
Ansible: Diff ( 10 files changed, 151 insertions(+), 47 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
Inspec: Diff ( 7 files changed, 14 insertions(+), 14 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177355"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceDNSKeys_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleCloudRunService_basic|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeImage|TestAccDataSourceComputeImageFilter|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceComputeNodeTypes_basic|TestAccComputeRegions_basic|TestAccInstanceTemplateDatasource_name|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceComputeInstance_basic|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRouter|TestAccDataSourceComputeSslCertificate|TestAccComputeZones_basic|TestAccDataSourceGoogleVpnGateway|TestAccDataSourceGoogleSslPolicy|TestAccComputeZones_filter|TestAccContainerEngineVersions_basic|TestAccContainerClusterDatasource_zonal|TestAccDataSourceGoogleSubnetwork|TestAccContainerClusterDatasource_regional|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceIAMRole|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccDataSourceGooglePubsubTopic_basic|TestAccRedisInstanceDatasource_basic|TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccIapClient_Datasource_basic|TestAccDatasourceSecretManagerSecretVersion_latest|TestAccDatasourceSecretManagerSecretVersion_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccTPUTensorflowVersions_basic|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccBigQueryDataset_cmek|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigqueryDataTransferConfig|TestAccBigQueryTable_Kms|TestAccBillingBudget_billingBudgetBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177358"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDNSKeys_basic|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleCloudRunService_basic|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeImage|TestAccDataSourceComputeAddress|TestAccDataSourceComputeImageFilter|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceComputeNodeTypes_basic|TestAccInstanceTemplateDatasource_name|TestAccInstanceTemplateDatasource_filter|TestAccComputeRegions_basic|TestAccDataSourceGoogleNetwork|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRouter|TestAccComputeZones_filter|TestAccDataSourceGoogleSubnetwork|TestAccComputeZones_basic|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceComputeSslCertificate|TestAccContainerEngineVersions_basic|TestAccDataSourceGoogleVpnGateway|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceIAMRole|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGooglePubsubTopic_basic|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccRedisInstanceDatasource_basic|TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccDatasourceSecretManagerSecretVersion_basic|TestAccIapClient_Datasource_basic|TestAccDatasourceSecretManagerSecretVersion_latest|TestAccDataSourceSqlDatabaseInstance_basic|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccTPUTensorflowVersions_basic|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccBigQueryDataset_cmek|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigqueryDataTransferConfig|TestAccBigQueryTable_Kms|TestAccBillingBudget_billingBudgetBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177360"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDNSKeys_basic|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleCloudRunService_basic|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeImage|TestAccDataSourceComputeAddress|TestAccDataSourceComputeImageFilter|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccDataSourceComputeNodeTypes_basic|TestAccInstanceTemplateDatasource_name|TestAccInstanceTemplateDatasource_filter|TestAccComputeRegions_basic|TestAccDataSourceGoogleNetwork|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRouter|TestAccComputeZones_filter|TestAccDataSourceGoogleSubnetwork|TestAccComputeZones_basic|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceComputeSslCertificate|TestAccContainerEngineVersions_basic|TestAccDataSourceGoogleVpnGateway|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceIAMRole|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGooglePubsubTopic_basic|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccRedisInstanceDatasource_basic|TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccDatasourceSecretManagerSecretVersion_basic|TestAccIapClient_Datasource_basic|TestAccDatasourceSecretManagerSecretVersion_latest|TestAccDataSourceSqlDatabaseInstance_basic|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccTPUTensorflowVersions_basic|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccBigQueryDataset_cmek|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigqueryDataTransferConfig|TestAccBigQueryTable_Kms|TestAccBillingBudget_billingBudgetBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177361"

[modular-magician]

Tests failed during RECORDING mode: TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceSqlDatabaseInstance_basic Please fix these to complete your PR

[modular-magician]

Tests failed during RECORDING mode: TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated Please fix these to complete your PR

[modular-magician]

Tests failed during RECORDING mode: TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccDataSourceSqlDatabaseInstance_basic|TestAccDataSourceComposerEnvironment_basic Please fix these to complete your PR