Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GCP overcommit CPU in Sole Tenant Nodes #8583

Comments

@damadei-google
Copy link

damadei-google commented Mar 1, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

GCP added support for CPU overcommit in Sole Tenant Nodes but there's no way to provision such instances this way using terraform

New or Affected Resource(s)

  • google_XXXXX

Potential Terraform Configuration

resource "google_compute_instance" "default" {
name = "test"
zone = "us-central1-c"
min_node_cpu = 4
}

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

https://cloud.google.com/sdk/gcloud/reference/compute/instances/create#--min-node-cpu

  • b/181562801
@ghost ghost added the enhancement label Mar 1, 2021
@rileykarson rileykarson added this to the Goals milestone Mar 8, 2021
@rileykarson rileykarson modified the milestones: Goals, Sprint 6 (2021) Mar 8, 2021
@ScottSuarez
Copy link
Collaborator

ScottSuarez commented Mar 15, 2021

This feature seems to already be supported in the beta provider. When provisioning a sole-tenant vm the api uses the scheduling field to associate the vm to the NODE_GROUP. Within the scheduling field we support min_node_cpus. I'll move this field to GA.

@ghost
Copy link

ghost commented Apr 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.