Generate SslCertificate in Terraform. #445
Conversation
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| @@ -0,0 +1,29 @@ | |||
| <% if false # the license inside this if block pertains to this file -%> | |||
There was a problem hiding this comment.
Two things! One: you can just use
<%#
Copyright 2017 ...
...
#%>
I know all the existing code does it this way but it's making me bonkers. :)
Two: this is really "name or name prefix", right? Might be worth naming it "templates/terraform/custom_expand/name_or_name_prefix.go.erb" instead.
| @@ -0,0 +1,17 @@ | |||
| "name_prefix": { | |||
There was a problem hiding this comment.
Thumbs up. Problem - consider using name ssl_certificate instead of sslCertificate.
| testAccCheckComputeSslCertificateExists( | ||
| "google_compute_ssl_certificate.foobar"), | ||
| ), | ||
| }, |
There was a problem hiding this comment.
I'd throw an import on all three tests, ignoring fields where necessary (like name_prefix on the name_prefix one).
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 8cefe69) have been included in your existing downstream PRs. |
Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible.
Generate SslCertificate in Terraform.
[all]
Minor schema/docs update to SslCertificate.
[terraform]
Autogenerate google_compute_ssl_certificate.
[puppet]
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]