-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix licenses that "assertain" to MM files. #455
Conversation
Hi, you're my favorite person. Can you un-commit the changes to the |
83968ec
to
7ae625b
Compare
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Huh, would you look at that? I should fix that one weird Ansible file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once you un-commit the submodule updates.
7ae625b
to
421b1fd
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit d7a9e52) have been included in your existing downstream PRs. |
1e59de0
to
421b1fd
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 316bff2) have been included in your existing downstream PRs. |
ef63af5
to
4b1818d
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 554525d) have been included in your existing downstream PRs. |
Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible.
Would you mind making an event in your calendar ~a week out to run whatever script you ran again? Just in case we committed old-format ones in the interim. |
@rileykarson 👍 the script is called "sublime find-replace is pretty dope" |
if false
with erb comment blocks.[all]
[terraform]
[puppet]
[puppet-bigquery]
[puppet-compute]
[puppet-container]
[puppet-dns]
[puppet-logging]
[puppet-pubsub]
[puppet-resourcemanager]
[puppet-sql]
[puppet-storage]
[chef]
[chef-compute]
[chef-container]
[chef-dns]
[chef-logging]
[chef-spanner]
[chef-sql]
[chef-storage]
[ansible]