Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHARED_LOADBALANCER_VIP purpose to regional addresses. #4169

Merged
merged 9 commits into from
Dec 10, 2020
Merged

Add SHARED_LOADBALANCER_VIP purpose to regional addresses. #4169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
71c3aeb
Merge pull request #1 from GoogleCloudPlatform/master
upodroid Aug 3, 2020
e1a9488
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid Aug 10, 2020
51eaff6
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid Aug 25, 2020
649e97c
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid Sep 21, 2020
ee373cc
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid Oct 3, 2020
d330773
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid Oct 27, 2020
c17f3aa
add extra option to enum validation
upodroid Oct 29, 2020
c9e9bbd
mark test as GA
upodroid Oct 30, 2020
276f9ca
remove beta from tests
upodroid Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions products/compute/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,27 +122,19 @@ objects:
required: true
- !ruby/object:Api::Type::Enum
name: purpose
exact_version: ga
description: |
The purpose of this resource, which can be one of the following values:

* GCE_ENDPOINT for addresses that are used by VM instances, alias IP ranges, internal load balancers, and similar resources.

This should only be set when using an Internal address.
values:
- :GCE_ENDPOINT
- !ruby/object:Api::Type::Enum
name: purpose
exact_version: beta
description: |
The purpose of this resource, which can be one of the following values:

* GCE_ENDPOINT for addresses that are used by VM instances, alias IP ranges, internal load balancers, and similar resources.
* SHARED_LOADBALANCER_VIP for an address that can be used by multiple internal load balancers.

* VPC_PEERING for addresses that are reserved for VPC peer networks.

This should only be set when using an Internal address.
values:
- :GCE_ENDPOINT
- :VPC_PEERING
- :SHARED_LOADBALANCER_VIP
- !ruby/object:Api::Type::Enum
name: 'networkTier'
Expand Down
1 change: 0 additions & 1 deletion products/compute/terraform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ overrides: !ruby/object:Overrides::ResourceOverrides
- !ruby/object:Provider::Terraform::Examples
name: "address_with_shared_loadbalancer_vip"
primary_resource_id: "internal_with_shared_loadbalancer_vip"
min_version: 'beta'
vars:
address_name: "my-internal-address"
skip_docs: true # It is almost identical to internal_with_gce_endpoint
Expand Down
1 change: 0 additions & 1 deletion templates/terraform/examples/address_with_shared_loadbalancer_vip.tf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
resource "google_compute_address" "<%= ctx[:primary_resource_id] %>" {
provider = google-beta
name = "<%= ctx[:vars]['address_name'] %>"
address_type = "INTERNAL"
purpose = "SHARED_LOADBALANCER_VIP"
Expand Down