-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHARED_LOADBALANCER_VIP purpose to regional addresses. #4169
Add SHARED_LOADBALANCER_VIP purpose to regional addresses. #4169
Conversation
Fork Update
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 8 insertions(+), 3 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test we can mark as GA as well to verify that this works?
Forgot about that, pushed a commit now. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 47 insertions(+), 3 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! I get notified on comments but not pushes (they're extremely noisy in practice) so I missed this. LGTM.
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=161489" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 46 insertions(+), 3 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceSpannerInstance_basic|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayGatewayIamBindingGenerated|TestAccApiGatewayGatewayIamMemberGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccComputeImageIamBindingGenerated|TestAccComputeImageIamMemberGenerated|TestAccComputeImageIamMemberGenerated_withCondition|TestAccComputeImageIamBindingGenerated_withCondition|TestAccComputeImageIamPolicyGenerated|TestAccComputeImageIamPolicyGenerated_withCondition|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayGateway_apigatewayGatewayBasicExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccBigqueryDataTransferConfig|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipExample|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceUpdate|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeAddress_addressWithSharedLoadbalancerVipExample|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_basic|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withCustomHeaders|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withSessionAffinity|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withLogConfig|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeImage_imageBasicExample|TestAccComputeImage_imageGuestOsExample|TestAccComputeImage_update|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeInstanceGroup_rename|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccGameServicesGameServerConfig_gameServiceConfigBasicExample|TestAccGameServicesGameServerDeploymentRollout_gameServiceDeploymentRolloutBasicExample|TestAccProjectIamCustomRole_basic|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingFolderSink_heredoc|TestAccLoggingOrganizationSink_heredoc|TestAccLoggingProjectSink_heredoc|TestAccSpannerDatabase_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=161490" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay on my part! LGTM
Fixes: hashicorp/terraform-provider-google#7652
The docs are all over the place.
gcloud compute addresses create foo --purpose SHARED_LOADBALANCER_VIP --project REDACTED --region europe-west6 --subnet default --log-http
works so I have made all 3 available at GA level.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)