Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHARED_LOADBALANCER_VIP purpose to regional addresses. #4169

Merged

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Oct 29, 2020

Fixes: hashicorp/terraform-provider-google#7652

The docs are all over the place.

gcloud compute addresses create foo --purpose SHARED_LOADBALANCER_VIP --project REDACTED --region europe-west6 --subnet default --log-http works so I have made all 3 available at GA level.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added SHARED_LOADBALANCER_VIP as a valid option for `google_compute_address.purpose`

@google-cla google-cla bot added the cla: yes label Oct 29, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 7 insertions(+), 3 deletions(-))
Ansible: Diff ( 2 files changed, 10 insertions(+), 1 deletion(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test we can mark as GA as well to verify that this works?

@upodroid
Copy link
Contributor Author

Forgot about that, pushed a commit now.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 47 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 14 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 10 insertions(+), 1 deletion(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upodroid
Copy link
Contributor Author

upodroid commented Dec 4, 2020

bump

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I get notified on comments but not pushes (they're extremely noisy in practice) so I missed this. LGTM.

@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=161489"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 46 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 14 insertions(+), 5 deletions(-))
Ansible: Diff ( 2 files changed, 10 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 1 file changed, 1 deletion(-))
Inspec: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceSpannerInstance_basic|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayGatewayIamBindingGenerated|TestAccApiGatewayGatewayIamMemberGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccComputeImageIamBindingGenerated|TestAccComputeImageIamMemberGenerated|TestAccComputeImageIamMemberGenerated_withCondition|TestAccComputeImageIamBindingGenerated_withCondition|TestAccComputeImageIamPolicyGenerated|TestAccComputeImageIamPolicyGenerated_withCondition|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccApiGatewayGateway_apigatewayGatewayBasicExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccBigqueryDataTransferConfig|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipExample|TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceUpdate|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeAddress_addressWithSharedLoadbalancerVipExample|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_basic|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withCustomHeaders|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withSessionAffinity|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withLogConfig|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeImage_imageBasicExample|TestAccComputeImage_imageGuestOsExample|TestAccComputeImage_update|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeInstanceGroup_rename|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccGameServicesGameServerConfig_gameServiceConfigBasicExample|TestAccGameServicesGameServerDeploymentRollout_gameServiceDeploymentRolloutBasicExample|TestAccProjectIamCustomRole_basic|TestAccLoggingBillingAccountSink_update|TestAccLoggingBillingAccountSink_heredoc|TestAccLoggingFolderSink_heredoc|TestAccLoggingOrganizationSink_heredoc|TestAccLoggingProjectSink_heredoc|TestAccSpannerDatabase_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=161490"

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay on my part! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow VPC_PEERING and SHARED_LOADBALANCER_VIP in google_compute_address.purpose
3 participants