Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistence_iam_identity to Redis Instance #3805

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Aug 3, 2020

Fixes hashicorp/terraform-provider-google#6850 . I also updated all the examples to use Redis 4.0 as it is the default one Google creates now.

Release Note Template for Downstream PRs (will be copied)

redis: added `persistence_iam_identity` output field to `google_redis_instance`
redis: explicitly noted in `google_redis_instance` documentation that `"REDIS_5_0"` is supported

@google-cla google-cla bot added the cla: yes label Aug 3, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 42 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 42 insertions(+), 6 deletions(-))
Ansible: Diff ( 2 files changed, 26 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Inspec: Diff ( 4 files changed, 8 insertions(+), 1 deletion(-))

products/redis/api.yaml Outdated Show resolved Hide resolved
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM- thanks for contributing @upodroid!

I'll merge once our CI has run. It's unlikely to fail- I'll comment again in the unlikely scenarios that I need anything else from you.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 29 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 29 insertions(+), 6 deletions(-))
Ansible: Diff ( 2 files changed, 26 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Inspec: Diff ( 4 files changed, 8 insertions(+), 1 deletion(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for redis 5.0 to google_redis_instance
3 participants