-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistence_iam_identity to Redis Instance #3805
Add persistence_iam_identity to Redis Instance #3805
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 42 insertions(+), 6 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM- thanks for contributing @upodroid!
I'll merge once our CI has run. It's unlikely to fail- I'll comment again in the unlikely scenarios that I need anything else from you.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 29 insertions(+), 6 deletions(-)) |
Fixes hashicorp/terraform-provider-google#6850 . I also updated all the examples to use Redis 4.0 as it is the default one Google creates now.
Release Note Template for Downstream PRs (will be copied)