Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support persistenceIamIdentity for google_redis_instance #5784

Closed
filip-sc opened this issue Feb 27, 2020 · 3 comments
Closed

Support persistenceIamIdentity for google_redis_instance #5784

filip-sc opened this issue Feb 27, 2020 · 3 comments

Comments

@filip-sc
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Please provide an attributes field persistenceIamIdentity for google_redis_instance. Currently there is no way as far as I can see, to access the underlying service account of gcp memstore for redis via terraform.

New or Affected Resource(s)

  • google_redis_instance

Potential Terraform Configuration

resource "google_redis_instance" "instance" {
  ...
}

resource "google_storage_bucket_iam_member" "memstore_object_bucket_writer" {
  bucket = "bucket"
  role = "roles/storage.legacyBucketWriter"
  member = "serviceAccount:${google_redis_instance.instance.persistence_iam_identity}"
}

References

@ghost ghost added the enhancement label Feb 27, 2020
@danawillow danawillow added this to the Goals milestone Mar 2, 2020
@webervin
Copy link

Not sure if it is worth stand-alone issue or not, but just because persistenceIamIdentity should be rechecked every time as it can change over time, it would be very good to also have a terraform data source for redis memorystore, so we could obtain relevant service account by instance name.

@upodroid
Copy link
Contributor

upodroid commented Aug 5, 2020

Hi

This value has been added now and should ship with provider version 3.34 which should be released next week.

GoogleCloudPlatform/magic-modules#3805

@megan07 megan07 closed this as completed Aug 20, 2020
@ghost
Copy link

ghost commented Sep 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants