Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Catalog Entry #3532

Merged

Conversation

danawillow
Copy link
Contributor

Part of hashicorp/terraform-provider-google#5892.

Intended to be reviewed after #3485, since it contains its commits as well.

Release Note Template for Downstream PRs (will be copied)

`google_data_catalog_entry`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 2846 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 16 files changed, 2846 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 3 files changed, 262 insertions(+))
TF OiCS: Diff ( 20 files changed, 593 insertions(+))

# We'll have people provide the json blob for the schema instead.
name: schema
description: |
Schema of the entry (e.g. BigQuery, GoogleSQL, Avro schema). An entry might not have any schema attached to it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add somewhere in the description that we're expecting the json blob? Or is it obvious? Maybe even a link to what the schema might look like?

* gs://another_bucket/a.txt: matches gs://another_bucket/a.txt
required: true
item_type: Api::Type::String
- !ruby/object:Api::Type::NestedObject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an Array?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 1595 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 10 files changed, 1595 insertions(+), 19 deletions(-))
TF Conversion: Diff ( 1 file changed, 198 insertions(+))
TF OiCS: Diff ( 12 files changed, 382 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants