-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Catalog Entry #3532
Data Catalog Entry #3532
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 16 files changed, 2846 insertions(+), 3 deletions(-)) |
products/datacatalog/api.yaml
Outdated
# We'll have people provide the json blob for the schema instead. | ||
name: schema | ||
description: | | ||
Schema of the entry (e.g. BigQuery, GoogleSQL, Avro schema). An entry might not have any schema attached to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add somewhere in the description that we're expecting the json blob? Or is it obvious? Maybe even a link to what the schema might look like?
products/datacatalog/api.yaml
Outdated
* gs://another_bucket/a.txt: matches gs://another_bucket/a.txt | ||
required: true | ||
item_type: Api::Type::String | ||
- !ruby/object:Api::Type::NestedObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an Array?
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 1595 insertions(+), 19 deletions(-)) |
Part of hashicorp/terraform-provider-google#5892.
Intended to be reviewed after #3485, since it contains its commits as well.
Release Note Template for Downstream PRs (will be copied)