Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Catalog EntryGroup #3485

Merged

Conversation

danawillow
Copy link
Contributor

Part of hashicorp/terraform-provider-google#5892.

I'm going to hold off on merging until a few more resources are ready, but breaking up into separate PRs for easier reviewability.

Release Note Template for Downstream PRs (will be copied)

`google_data_catalog_entry_group`
`google_data_catalog_entry_group_iam_member`
`google_data_catalog_entry_group_iam_binding`
`google_data_catalog_entry_group_iam_policy`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 11 files changed, 1282 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 11 files changed, 1282 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 2 files changed, 67 insertions(+))
TF OiCS: Diff ( 8 files changed, 211 insertions(+))

@danawillow danawillow mentioned this pull request May 18, 2020
@danawillow danawillow requested a review from megan07 May 18, 2020 23:55
@danawillow
Copy link
Contributor Author

FYI import is not so great in this PR but I fixed it in #3532. As long as they're both in the same TPG release, I'm not concerned.

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EntryGroup looks good! I will review TagTemplates once it's uncommented - I actually learned a lot from your PR - on things I should be aware of when I'm writing out resources, so wanted to thank you for that too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants