Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to schema #1 #3507

Merged
merged 3 commits into from
May 15, 2020

Conversation

edwardmedia
Copy link
Contributor

Part of hashicorp/terraform-provider-google#6105

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 10 insertions(+))
Terraform Beta: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@edwardmedia edwardmedia requested review from danawillow and removed request for slevenick May 13, 2020 19:10
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 30 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 1 file changed, 30 insertions(+), 20 deletions(-))

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please hold off on merging until Nathan posts in slack that it's safe to do so.

@edwardmedia edwardmedia merged commit 8951f33 into GoogleCloudPlatform:master May 15, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…#3507)

* add descriptions to the schema

* add descriptions to schema

* run go fmt

Co-authored-by: Edward Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants