Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some resource schemas lack field descriptions #6105

Closed
xiaobaitusi opened this issue Apr 13, 2020 · 3 comments
Closed

Some resource schemas lack field descriptions #6105

xiaobaitusi opened this issue Apr 13, 2020 · 3 comments

Comments

@xiaobaitusi
Copy link

xiaobaitusi commented Apr 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Some resource schemas lack field descriptions, e.g ContainerCluster and ContainerNodePool.

New or Affected Resource(s)

It's ideal to have field descriptions for every resource but the following resources are complicated enough to require inline field description in schema.

  • google_container_cluster (done by Edward)
  • google_container_node_pool (done by Edward)
  • google_sql_database_instance (claimed by Thomas)
  • google_storage_bucket (claimed by Thomas)
  • google_compute_instance (done by Edward)
@ghost ghost added the enhancement label Apr 13, 2020
@danawillow danawillow added this to the Near-Term Goals milestone Apr 20, 2020
@edwardmedia edwardmedia self-assigned this May 6, 2020
@danawillow
Copy link
Contributor

Adding google_bigtable_instance (and probably _table just for consistency) as per email conversation.

This was referenced Jun 19, 2020
@edwardmedia
Copy link
Contributor

Closing the issue as descriptions have been added to the schema in above resources.

@ghost
Copy link

ghost commented Aug 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants