Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-guard node_locations on google_container_node_pool resource #3444

Merged

Conversation

ewolak-sq
Copy link
Contributor

@ewolak-sq ewolak-sq commented Apr 30, 2020

As far as I can tell from the official documentation, this feature is now GA, so we can use it in the "google" provider.

This is a follow-up to #2320

@rileykarson

Release Note Template for Downstream PRs (will be copied)

* container: added `node_locations` to `google_container_node_pool` and `google_container_cluster.node_pool` (now available in GA)

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 100 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@danawillow danawillow self-requested a review April 30, 2020 16:49
As far as I can tell from the [official documentation](https://cloud.google.com/sdk/gcloud/reference/container/node-pools/create), this feature is now GA, so we can use it in the "google" provider.
@ewolak-sq ewolak-sq force-pushed the node-pool-locations-ga branch from de2d8b7 to 7facbba Compare April 30, 2020 17:06
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 124 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@danawillow
Copy link
Contributor

Looks good! Thanks @ewolak-sq!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants