Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node_locations to google_container_node_pool. #2320

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Add support for node_locations to google_container_node_pool. #2320

merged 3 commits into from
Sep 17, 2019

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#3992

Release Note for Downstream PRs (will be copied)

google_container_node_pool now supports node_locations to specify specific node zones.

emilymye
emilymye approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just some docs things - also conversion looks like it needs a rebase

third_party/terraform/website/docs/r/container_node_pool.html.markdown Outdated
@@ -131,6 +131,15 @@ type-specific `region` for regional clusters / `zone` for zonal clusters.
See the [official documentation](https://cloud.google.com/kubernetes-engine/docs/how-to/flexible-pod-cidr)
for more information.

* `node_locations` - (Optional) The list of zones in which the node pool's nodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional, Beta?

third_party/terraform/tests/resource_container_node_pool_test.go.erb Outdated
cluster = "${google_container_cluster.cluster.name}"

initial_node_count = 1
node_locations = ["us-central1-a", "us-central1-c"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nbd whitespace is the worst

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cef8432.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1154
depends: hashicorp/terraform-provider-google#4478

@rileykarson
Copy link
Member Author

The Magician is using an ugly diffbase, and I can't get it to clean itself up (unless I was to delete the downstreams). Merging with ugly diffs.

rileykarson and others added 3 commits September 17, 2019 21:02
@rileykarson @modular-magician
Add support for node_locations to google_container_node_pool.
d26235a
@rileykarson @modular-magician
Review comments
58eca88
@modular-magician
Update tracked submodules -> HEAD on Tue Sep 17 21:02:26 UTC 2019
9009193 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 030eaf2 into GoogleCloudPlatform:master Sep 17, 2019
@rileykarson rileykarson mentioned this pull request Sep 19, 2019
Closed
@morgante morgante mentioned this pull request Oct 21, 2019
Closed
@ewolak-sq ewolak-sq mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GKE NodePool locations list in google_container_node_pool
4 participants
@rileykarson @modular-magician @emilymye @googlebot