Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notificationConfigs for healthcare Hl7V2 #3417

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Apr 23, 2020

The healthcare API has deprecated a field at beta and removed it from the GA
launch of the api. In order to support this without having to duplicate the
entire resource this change supports defining a single field multiple times
with a different configruation for each version. Specifically it allows a field
to exist as deprecated at one version but not at another.
This also introduces the removed_message field.

This is another follow on to #3377 which GA'ed this resource without addressing the removed fields.

TODO - this change requires vendoring changes in both downstream repos.

Release Note Template for Downstream PRs (will be copied)

`google_healthcare_dataset` is now GA
`google_healthcare_dicom_store` is now GA
`google_healthcare_fhir_store` is now GA
`google_healthcare_hl7_v2_store` is now GA
`google_healthcare_dataset_iam_binding` is now GA
`google_healthcare_dataset_iam_member` is now GA
`google_healthcare_dataset_iam_policy` is now GA
`google_healthcare_dicom_store_iam_binding` is now GA
`google_healthcare_dicom_store_iam_member` is now GA
`google_healthcare_dicom_store_iam_policy` is now GA
`google_healthcare_fhir_store_iam_binding` is now GA
`google_healthcare_fhir_store_iam_member` is now GA
`google_healthcare_fhir_store_iam_policy` is now GA
`google_healthcare_hl7_v2_store_iam_binding` is now GA
`google_healthcare_hl7_v2_store_iam_member` is now GA
`google_healthcare_hl7_v2_store_iam_policy` is now GA

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 153 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 8 files changed, 166 insertions(+), 11 deletions(-))
TF Conversion: Diff ( 1 file changed, 43 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

The healthcare API has deprecated a field at beta and removed it from the GA
launch of the api. In order to support this without having to duplicate the
entire resource this change supports defining a single field multiple times
with a different configruation for each version. Specifically it allows a field
to exist as deprecated at one version but not at another.
This also introduces the removed_message field.
@chrisst chrisst force-pushed the healthcare-deprecations branch from 561cf71 to f7493c8 Compare April 24, 2020 00:19
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 154 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 9 files changed, 167 insertions(+), 12 deletions(-))
TF Conversion: Diff ( 2 files changed, 44 insertions(+), 1 deletion(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@chrisst chrisst requested a review from nat-henderson April 24, 2020 00:30
@chrisst chrisst merged commit 9f6fb89 into GoogleCloudPlatform:master Apr 24, 2020
@chrisst chrisst deleted the healthcare-deprecations branch April 24, 2020 00:43
@chrisst chrisst changed the title Allow fields to be removed at a specific version Add notificationConfigs for healthcare Hl7V2 Apr 27, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…#3417)

The healthcare API has deprecated a field at beta and removed it from the GA
launch of the api. In order to support this without having to duplicate the
entire resource this change supports defining a single field multiple times
with a different configruation for each version. Specifically it allows a field
to exist as deprecated at one version but not at another.
This also introduces the removed_message field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants