Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote healthcare resources to GA #3377

Merged
merged 7 commits into from
Apr 21, 2020
Merged

Promote healthcare resources to GA #3377

merged 7 commits into from
Apr 21, 2020

Conversation

umairidris
Copy link
Member

@umairidris umairidris commented Apr 15, 2020

Release Note Template for Downstream PRs (will be copied)

`google_healthcare_dataset` is now GA
`google_healthcare_dicom_store` is now GA
`google_healthcare_fhir_store` is now GA
`google_healthcare_hl7_v2_store` is now GA

@umairidris umairidris changed the title add GA healthcare API Promote healthcare resources to GA Apr 15, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 17 files changed, 2951 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 321 insertions(+), 109 deletions(-))
TF Conversion: Diff ( 5 files changed, 457 insertions(+))
TF OiCS: Diff ( 12 files changed, 356 insertions(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 17 files changed, 2954 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 324 insertions(+), 115 deletions(-))
TF Conversion: Diff ( 5 files changed, 457 insertions(+))
TF OiCS: Diff ( 12 files changed, 356 insertions(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@danawillow danawillow requested a review from chrisst April 16, 2020 20:39
@danawillow
Copy link
Contributor

(PR comes from a googler so I rolled a metaphorical die)

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! There's a couple quick things you'll need to fix before this can be merged. I commented on some of them inline, but also can you remove the version checking for the healthcare documentation in third_party/terraform/website-compiled/google.erb

@umairidris umairidris requested a review from chrisst April 17, 2020 01:13
@umairidris
Copy link
Member Author

Addressed comments, PTAL!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 26 files changed, 5121 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 16 files changed, 364 insertions(+), 121 deletions(-))
TF Conversion: Diff ( 5 files changed, 457 insertions(+))
TF OiCS: Diff ( 12 files changed, 356 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 5206 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 17 files changed, 476 insertions(+), 148 deletions(-))
TF Conversion: Diff ( 5 files changed, 457 insertions(+))
TF OiCS: Diff ( 16 files changed, 483 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 5206 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 17 files changed, 476 insertions(+), 148 deletions(-))
TF Conversion: Diff ( 5 files changed, 457 insertions(+))
TF OiCS: Diff ( 16 files changed, 483 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 5352 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 17 files changed, 372 insertions(+), 127 deletions(-))
TF Conversion: Diff ( 5 files changed, 479 insertions(+))
TF OiCS: Diff ( 13 files changed, 356 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 28 files changed, 5566 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 15 files changed, 340 insertions(+), 122 deletions(-))
TF Conversion: Diff ( 5 files changed, 479 insertions(+))
TF OiCS: Diff ( 13 files changed, 356 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 28 files changed, 5558 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 12 files changed, 334 insertions(+), 124 deletions(-))
TF Conversion: Diff ( 5 files changed, 479 insertions(+))
TF OiCS: Diff ( 13 files changed, 356 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 28 files changed, 5570 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 12 files changed, 331 insertions(+), 122 deletions(-))
TF Conversion: Diff ( 5 files changed, 492 insertions(+))
TF OiCS: Diff ( 13 files changed, 356 insertions(+), 4 deletions(-))

@chrisst
Copy link
Contributor

chrisst commented Apr 21, 2020

builds are passing 👍 I ran a subset of tests locally and they are passing too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants