-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote healthcare resources to GA #3377
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 17 files changed, 2951 insertions(+), 2 deletions(-)) |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 17 files changed, 2954 insertions(+), 2 deletions(-)) |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
(PR comes from a googler so I rolled a metaphorical die) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding! There's a couple quick things you'll need to fix before this can be merged. I commented on some of them inline, but also can you remove the version checking for the healthcare documentation in third_party/terraform/website-compiled/google.erb
Addressed comments, PTAL! |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 26 files changed, 5121 insertions(+), 2 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 27 files changed, 5206 insertions(+), 2 deletions(-)) |
1 similar comment
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 27 files changed, 5206 insertions(+), 2 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 27 files changed, 5352 insertions(+), 2 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 28 files changed, 5566 insertions(+), 11 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 28 files changed, 5558 insertions(+), 11 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 28 files changed, 5570 insertions(+), 11 deletions(-)) |
builds are passing 👍 I ran a subset of tests locally and they are passing too. |
* add GA healthcare API * add ga resources to website * rename test files * stop skipping hl7 test * Removing erb syntax and GA's utils file * formatting and fixing imports * move client config to GA and cleanup tests Co-authored-by: Chris Stephens <[email protected]>
Release Note Template for Downstream PRs (will be copied)