Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make display name optional on monitoring notification channel #3365

Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Apr 10, 2020

I could go either way on this, but to stay consistent with the API, I made it Optional. If we think it should be Required (since that is the recommendation of the API), I'm happy to just make a doc update.

Fixes hashicorp/terraform-provider-google#6084

Release Note Template for Downstream PRs (will be copied)

monitoring: made `display_name` optional on `google_monitoring_notification_channel `

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 9 deletions(-))

@megan07 megan07 requested a review from chrisst April 10, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_monitoring_notification_channel requires display_name
4 participants