Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_monitoring_notification_channel requires display_name #6084

Closed
nesl247 opened this issue Apr 9, 2020 · 3 comments · Fixed by GoogleCloudPlatform/magic-modules#3365, #6090 or hashicorp/terraform-provider-google-beta#1947
Assignees
Labels

Comments

@nesl247
Copy link

nesl247 commented Apr 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

N/A

Affected Resource(s)

  • google_monitoring_notification_channel

Terraform Configuration Files

N/A

Debug Output

N/A

Panic Output

N/A

Expected Behavior

display_name should not be required or the description should not say it is optional

Actual Behavior

display_name is required

Steps to Reproduce

See https://www.terraform.io/docs/providers/google/r/monitoring_notification_channel.html#display_name

Important Factoids

N/A

References

@ghost ghost added the bug label Apr 9, 2020
@edwardmedia edwardmedia self-assigned this Apr 9, 2020
@edwardmedia
Copy link
Contributor

display_name is required. Please update doc for this field accordingly

@edwardmedia edwardmedia assigned megan07 and unassigned edwardmedia Apr 9, 2020
@nesl247
Copy link
Author

nesl247 commented Apr 9, 2020

@edwardmedia Out of curiosity, why is it required? Because it isn't required on GCP's web console.

As in, we should default to '' instead of making this required.

@ghost
Copy link

ghost commented May 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 11, 2020
@github-actions github-actions bot added service/monitoring-alerting forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.