Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vpc_connector to update #3211

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Mar 4, 2020

Added vpc_connector to update function.

Fixes hashicorp/terraform-provider-google#5811

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: fixed `vpc_connector` to be updated properly in `google_cloudfunctions_function`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 26 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 26 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@megan07 megan07 requested a review from emilymye March 4, 2020 17:48
@megan07 megan07 force-pushed the megan_vpc_connector branch from d2baa5f to a453e7a Compare March 4, 2020 18:05
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 26 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 26 insertions(+), 7 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudfunctions_function: vpc_connector not updated in-place
4 participants