-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vpc_connector to cloud function on update #3201
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @danawillow, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Priyam-tricon! Can you also please add an update step to TestAccCloudFunctionsFunction_vpcConnector
? You can see an example of how to do so in the TestAccCloudFunctionsFunction_bucket
test. Check out https://github.com/GoogleCloudPlatform/magic-modules#testing-your-changes for how to run it yourself if you'd like to do so before sending it back out.
third_party/terraform/resources/resource_cloudfunctions_function.go
Outdated
Show resolved
Hide resolved
third_party/terraform/resources/resource_cloudfunctions_function.go
Outdated
Show resolved
Hide resolved
Hi @danawillow, I have done the changes. |
third_party/terraform/tests/resource_cloudfunctions_function_test.go.erb
Outdated
Show resolved
Hide resolved
third_party/terraform/tests/resource_cloudfunctions_function_test.go.erb
Outdated
Show resolved
Hide resolved
Hi @danawillow , sorry, it looks like #3211 fixes this issue. |
Ah, sorry about the conflict, but glad it gets fixed at the end of the day :) Closing. |
Release Note Template for Downstream PRs (will be copied)