Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vpc_connector to cloud function on update #3201

Closed
wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2020

Release Note Template for Downstream PRs (will be copied)

      feat: add vpc_connector to cloud function on update

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 5 insertions(+))
Terraform Beta: Diff ( 1 file changed, 5 insertions(+))

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Priyam-tricon! Can you also please add an update step to TestAccCloudFunctionsFunction_vpcConnector? You can see an example of how to do so in the TestAccCloudFunctionsFunction_bucket test. Check out https://github.com/GoogleCloudPlatform/magic-modules#testing-your-changes for how to run it yourself if you'd like to do so before sending it back out.

@ghost
Copy link
Author

ghost commented Mar 4, 2020

Hi @danawillow, I have done the changes.
I have written the test case too, but unfortunately I haven't run it.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 82 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 82 insertions(+), 3 deletions(-))

@ghost
Copy link
Author

ghost commented Mar 5, 2020

Hi @danawillow , sorry, it looks like #3211 fixes this issue.
I think we should close this.

@danawillow
Copy link
Contributor

Ah, sorry about the conflict, but glad it gets fixed at the end of the day :)

Closing.

@danawillow danawillow closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants