-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service account description uses patch for updates. #2650
Service account description uses patch for updates. #2650
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
The service account description is also not updateable via the API Explorer. Maybe because the
Update 1: It works via the gcloud cli:
Update 2: If you create a new service account via terraform, the description field will be set correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it your experience that https://cloud.google.com/iam/docs/reference/rest/v1/projects.serviceAccounts/patch#google.iam.admin.v1.IAM.PatchServiceAccount didn't work? Update indicates that description
is updatable as well.
If both don't work, can you file a bug against the service team? description
clearly should be updatable.
@rileykarson only tried https://cloud.google.com/iam/docs/reference/rest/v1/projects.serviceAccounts/update with the API Explorer. I can test /patch tomorrow at work. |
Ah, yep, |
78b97f0
to
393a56b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the same update method for both + add a test updating description?
Done, test passes. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
507d516
to
b135c11
Compare
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#4868.