Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_service_account description not properly updating #4868

Closed
tdgeery opened this issue Nov 12, 2019 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#2650
Closed
Assignees
Labels
bug forward/review In review; remove label to forward service/iam-serviceaccount

Comments

@tdgeery
Copy link

tdgeery commented Nov 12, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.12.13
+ provider.google v2.19.0
+ provider.google-beta v2.19.0
+ provider.kubernetes v1.10.0
+ provider.null v2.1.2
+ provider.random v2.2.1
+ provider.vault v2.6.0

Affected Resource(s)

  • google_service_account

Terraform Configuration Files

resource "google_service_account" "testing123" {
  project      = data.terraform_remote_state.service_project.outputs.project_id
  account_id   = "testing123"
  display_name = "testing123"
  description  = "Test Description... 123"
}

Expected Behavior

# google_service_account.testing123 will be updated in-place
~ resource "google_service_account" "testing123" {
    account_id   = "testing123"
  ~ description  = "Test Description" -> "Test Description... 123"
    display_name = "testing123"
    email        = "testing123@<project-id>.iam.gserviceaccount.com"
    id           = "projects/<project-id>/serviceAccounts/testing123@<project-id>.iam.gserviceaccount.com"
    name         = "projects/<project-id>/serviceAccounts/testing123@<project-id>.iam.gserviceaccount.com"
    project      = "<project-id>"
}

Actual Behavior

When trying to add or modify the description of a Service Account, the apply completes successfully but resource is not properly updated. Second run of plan/apply shows it still needs to be modified.

Steps to Reproduce

  1. Add/Modify description argument to already created Service Account
  2. terraform apply
  3. Describe your service account via gcloud or look at the console for updated description
  4. Rerun terraform apply

Important Factoids

Only occurs when the service account has already been created, and you're modifying/adding a description

@nat-henderson
Copy link
Contributor

It may be that descriptions aren't modifiable - I'll take a look.

@ghost
Copy link

ghost commented Dec 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 13, 2019
@github-actions github-actions bot added service/iam-serviceaccount forward/review In review; remove label to forward labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/iam-serviceaccount
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants