Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version behaviour in google_compute_instance_group #2506

Merged

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Oct 22, 2019

Fixes TestAccComputeInstanceGroup_network, TestAccComputeInstanceGroup_update

Followup to #2483

Release Note Template for Downstream PRs (will be copied)

`compute`: fixed diffs in `google_compute_instance_group`'s `network` field when equivalent values were specified
`compute`: fixed issues updating `google_compute_instance_group`'s `instances` field when config/state values didn't match

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e2f1f22.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1286
depends: hashicorp/terraform-provider-google#4728

@rileykarson rileykarson changed the title Add a DSF to GCE IG 'network' Fix version behaviour in google_compute_instance_group Oct 22, 2019
@rileykarson rileykarson requested a review from megan07 October 22, 2019 17:06
@rileykarson
Copy link
Member Author

@megan07: Got another test that was failing, and the fix ended up touching a different part of the resource. Mind taking another look?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 63db0bb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#235

rileykarson and others added 3 commits October 22, 2019 19:25
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 211fc75 into GoogleCloudPlatform:master Oct 22, 2019
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants