Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove built-in version from service client basepaths #2483

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Remove built-in version from service client basepaths #2483

merged 2 commits into from
Oct 16, 2019

Conversation

rileykarson
Copy link
Member

Fixes b/142822846

Release Note Template for Downstream PRs (will be copied)

various: fixed the custom endpoint version used by older legacy REST clients

danawillow
danawillow approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove the version + add it back in the first place?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3bd45ef.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1274
depends: GoogleCloudPlatform/terraform-google-conversion#231
depends: hashicorp/terraform-provider-google#4695

@rileykarson
Copy link
Member Author

Most service clients' base paths don't include versions, but Compute and a few others do. In most clients, a separate variable (that I don't think I can modify) holds the version. For consistency, I added the version back on the URL for clients that had it there, thinking it was part of the schema or something.

@modular-magician
Update tracked submodules -> HEAD on Wed Oct 16 23:25:27 UTC 2019
2962758 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 50d6d1c into GoogleCloudPlatform:master Oct 16, 2019
This was referenced Oct 17, 2019
Merged
Merged
Merged
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@rileykarson @JanMa
Remove built-in version from service client basepaths (GoogleCloudPla…
48548f5 
…tform#2483)

Merged PR GoogleCloudPlatform#2483.
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
@JanMa
Revert "Remove built-in version from service client basepaths (Google…
be68598 
…CloudPlatform#2483)"

This reverts commit 48548f5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileykarson @modular-magician @danawillow @googlebot