Changes to Add Inspec for Spanner instance and database

[callppatel]

Just opened new one. Looks like there was some additional commit showing in old one #2479

@slevenick - Please review this.

Inspec for Spanner instance and database

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

[slevenick]

The spanner inspec.yaml contains references to App Engine resources, so MM fails to compile

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b0a2e8e.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1276
depends: hashicorp/terraform-provider-google#4700
depends: modular-magician/inspec-gcp#235

[callppatel]

@slevenick - Please let me know if any more feedback. Thanks.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 462605d.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

[slevenick]

Getting an error attempting to run the integration tests:

Error: Unsupported argument

  on gcp-mm.tf line 874, in resource "google_spanner_instance" "spanner_instance":
 874:   node_count   = "${var.spannerinstance["node_count"]}"

An argument named "node_count" is not expected here.

Also there have been updates to the terraform file and attributes file, can you rebase off of the current master?

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[callppatel]

@slevenick - Looks like rebasing is messed up. Opened new one #2519. this can be closed.