-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Bigtable instance type from InstanceInfo instead of deriving from clusters #2488
Extract Bigtable instance type from InstanceInfo instead of deriving from clusters #2488
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @rambleraptor, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM- there's one small thing, I'm going apply it myself if I have permissions to do so.
Edit: Darn, looks like I don't. Do you mind applying that change?
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Co-Authored-By: Riley Karson <[email protected]>
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
d30fe62
to
8f04ef5
Compare
…eriving from clusters (GoogleCloudPlatform#2488)" This reverts commit c58df27.
This PR makes a simple tweak to the
Read
function used for Terraform'sgoogle_bigtable_instance
to extract the instance type from thebigtable.InstanceInfo
fetched from the Bigtable Admin API instead of deriving it from the cluster configuration.Release Note Template for Downstream PRs (will be copied)