Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Bigtable instance type from InstanceInfo instead of deriving from clusters #2488

Conversation

nickmoorman
Copy link
Contributor

This PR makes a simple tweak to the Read function used for Terraform's google_bigtable_instance to extract the instance type from the bigtable.InstanceInfo fetched from the Bigtable Admin API instead of deriving it from the cluster configuration.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- there's one small thing, I'm going apply it myself if I have permissions to do so.

Edit: Darn, looks like I don't. Do you mind applying that change?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 15e8075.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1288
depends: hashicorp/terraform-provider-google#4730

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d30fe62.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

nickmoorman and others added 3 commits October 23, 2019 15:49
Co-Authored-By: Riley Karson <[email protected]>
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the extract-bigtable-instance-type-from-instanceinfo branch from d30fe62 to 8f04ef5 Compare October 23, 2019 15:49
@modular-magician modular-magician merged commit 939c0c0 into GoogleCloudPlatform:master Oct 23, 2019
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants