Add endpoints service IAM #2318

slevenick · 2019-09-14T00:38:36Z

Fixes hashicorp/terraform-provider-google#3617

Release Note for Downstream PRs (will be copied)

google_endpoints_service_iam_binding

google_endpoints_service_iam_policy

google_endpoints_service_iam_member

modular-magician · 2019-09-14T00:46:50Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 489f02d.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1139
depends: GoogleCloudPlatform/terraform-google-conversion#201
depends: hashicorp/terraform-provider-google#4456

modular-magician · 2019-09-18T19:37:30Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d7b4ac1.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow · 2019-09-18T22:44:58Z

products/endpoints/api.yaml

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# TODO(nelsonjr): Make all Zone and Region resource ref


nit: this can be removed

danawillow · 2019-09-18T22:47:40Z

products/endpoints/api.yaml

+versions:
+  - !ruby/object:Api::Product::Version
+    name: ga
+    base_url: https://servicemanagement.googleapis.com/v1/


So one thing that appears to have been generated is the endpoints custom endpoint, which is a bit tricky since the existing endpoints_service resource uses the service management custom endpoint. I think it would be better if there were just one custom endpoint for the endpoints_service resource and its associated IAM resources.

So change this to the service management product, and override the name via legacy name? It may be hard to match up the IAM resource to be named similarly to the google_endpoints_service resource

It's definitely going to need some thought on how to do it well. One option would be to create a function to determine the custom endpoint name, which would return a custom_endpoint_name value set in terraform.yaml, and default to whatever we currently use.

Renamed the product to ServiceManagement and then overrode the name of the IAM resources to match the existing handwritten resource

modular-magician · 2020-02-10T20:28:13Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 558 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 558 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))

modular-magician · 2020-02-10T20:30:49Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 558 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 558 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))

…th endpoints_service resource

modular-magician · 2020-02-10T21:46:57Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 559 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 6 files changed, 559 insertions(+), 16 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 14 deletions(-))

modular-magician · 2020-02-10T22:55:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 559 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 6 files changed, 559 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 14 deletions(-))

danawillow

Can you also update google.erb for the sidebar?

modular-magician · 2020-02-11T00:09:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 568 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 7 files changed, 568 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 14 deletions(-))

modular-magician · 2020-02-11T00:18:19Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 568 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 7 files changed, 568 insertions(+), 18 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 14 deletions(-))

danawillow

You'll also want to update the changelog note to whatever we do differently now than we did in september

danawillow · 2020-02-11T00:33:07Z

third_party/terraform/utils/provider_handwritten_endpoint.go.erb

@@ -173,17 +173,6 @@ var RuntimeConfigCustomEndpointEntry = &schema.Schema{
 	}, RuntimeConfigDefaultBasePath),
 }

-var ServiceManagementDefaultBasePath = "https://servicemanagement.googleapis.com/v1/"


Hmm I think we do need to leave these in until 4.0.0 so that anyone that was setting the custom endpoint still can

Oh gosh, I keep changing the product name to make the docs line up right but the product name also goes in here 🤦‍♂

Fixed by changing the docs to use the product's display name and moving the product that produces this IAM resource to use the same namespace as the existing handwritten one.

modular-magician · 2020-02-11T22:30:49Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 580 insertions(+), 30 deletions(-))
Terraform Beta: Diff ( 10 files changed, 580 insertions(+), 30 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 14 deletions(-))

modular-magician · 2020-02-12T02:20:56Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 614 insertions(+), 98 deletions(-))
Terraform Beta: Diff ( 24 files changed, 617 insertions(+), 103 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 14 deletions(-))

modular-magician · 2020-02-12T02:38:47Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 632 insertions(+), 82 deletions(-))
Terraform Beta: Diff ( 24 files changed, 636 insertions(+), 86 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 insertions(+), 14 deletions(-))

* Add endpoints service IAM resources

googlebot added the cla: yes label Sep 14, 2019

modular-magician added downstream-generated terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Sep 14, 2019

slevenick added the changelog: new-resource label Sep 16, 2019

slevenick force-pushed the endpoints-service-iam branch from 489f02d to d7b4ac1 Compare September 18, 2019 19:29

slevenick requested a review from danawillow September 18, 2019 21:44

danawillow reviewed Sep 18, 2019

View reviewed changes

rileykarson removed the changelog: new-resource label Oct 8, 2019

slevenick added 2 commits February 10, 2020 12:21

Add endpoints service IAM

2dcf806

Update dates

a5870b0

slevenick force-pushed the endpoints-service-iam branch from d7b4ac1 to a5870b0 Compare February 10, 2020 20:22

Dates again

e81d596

Rename to servicemanagement product, legacyname to override to fit wi…

405e831

…th endpoints_service resource

Remove duplicate endpoint code, these are generated now

e110d51

slevenick requested a review from danawillow February 10, 2020 23:02

danawillow reviewed Feb 10, 2020

View reviewed changes

rename and add to website erb

8498e65

Rename display name

c737258

slevenick requested a review from danawillow February 11, 2020 00:19

danawillow reviewed Feb 11, 2020

View reviewed changes

Legacyname/product name fixes in IAM docs

ee91d33

Use display name in iam docs

3a7f80b

Extra new lines needed in iam docs

6b16fba

slevenick requested a review from danawillow February 12, 2020 21:13

danawillow approved these changes Feb 12, 2020

View reviewed changes

slevenick merged commit ab4c761 into GoogleCloudPlatform:master Feb 13, 2020

This was referenced Feb 13, 2020

Add endpoints service IAM hashicorp/terraform-provider-google#5668

Merged

Add endpoints service IAM hashicorp/terraform-provider-google-beta#1761

Merged

nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020

Add endpoints service IAM (GoogleCloudPlatform#2318)

13abfe4

* Add endpoints service IAM resources

roaks3 mentioned this pull request Sep 29, 2023

Failing test(s): ServiceManagementService generated tests hashicorp/terraform-provider-google#13088

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add endpoints service IAM #2318

Add endpoints service IAM #2318

slevenick commented Sep 14, 2019 •

edited

Loading

modular-magician commented Sep 14, 2019

modular-magician commented Sep 18, 2019

danawillow Sep 18, 2019

danawillow Sep 18, 2019

slevenick Sep 18, 2019 •

edited

Loading

danawillow Sep 18, 2019

slevenick Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 10, 2020

danawillow left a comment

modular-magician commented Feb 11, 2020

modular-magician commented Feb 11, 2020

danawillow left a comment

danawillow Feb 11, 2020

slevenick Feb 11, 2020

slevenick Feb 12, 2020

modular-magician commented Feb 11, 2020

modular-magician commented Feb 12, 2020

modular-magician commented Feb 12, 2020

Add endpoints service IAM #2318

Add endpoints service IAM #2318

Conversation

slevenick commented Sep 14, 2019 • edited Loading

Release Note for Downstream PRs (will be copied)

modular-magician commented Sep 14, 2019

Pull request statuses

New Pull Requests

modular-magician commented Sep 18, 2019

Pull request statuses

New Pull Requests

danawillow Sep 18, 2019

Choose a reason for hiding this comment

danawillow Sep 18, 2019

Choose a reason for hiding this comment

slevenick Sep 18, 2019 • edited Loading

Choose a reason for hiding this comment

danawillow Sep 18, 2019

Choose a reason for hiding this comment

slevenick Feb 10, 2020

Choose a reason for hiding this comment

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

danawillow left a comment

Choose a reason for hiding this comment

modular-magician commented Feb 11, 2020

Diff report:

modular-magician commented Feb 11, 2020

Diff report:

danawillow left a comment

Choose a reason for hiding this comment

danawillow Feb 11, 2020

Choose a reason for hiding this comment

slevenick Feb 11, 2020

Choose a reason for hiding this comment

slevenick Feb 12, 2020

Choose a reason for hiding this comment

modular-magician commented Feb 11, 2020

Diff report:

modular-magician commented Feb 12, 2020

Diff report:

modular-magician commented Feb 12, 2020

Diff report:

slevenick commented Sep 14, 2019 •

edited

Loading

slevenick Sep 18, 2019 •

edited

Loading