Failing test(s): ServiceManagementService generated tests

[melinath]

Affected Resource(s)

• google_endpoints_service
• google_endpoints_service_iam_binding

The following ServiceManagementService generated tests were added (but didn't get generated at the time due to #13138) and do not pass. We should fix them or determine they are not needed.

• TestAccServiceManagementService_endpointsIamExample
• TestAccServiceManagementServiceConsumers_endpointsIamExample

[roaks3]

Note: these tests were added a long time ago in GoogleCloudPlatform/magic-modules#2318, and I do not see anything IAM-related in them. My guess is that they were used in some previous iteration of magic-modules where a base example might have been used.

We do currently have *IamMemberGenerated, *IamBindingGenerated, and *IamPolicyGenerated tests for each resource, so the IAM behavior appears to be covered, and I would think we can remove these.

cc @slevenick in case you remember any context from ~4 years ago

[melinath]

I ended up re-spelunking on this ticket because I'd forgotten the context. To summarize (hopefully better this time):

• We have resources defined in servicemanagement/Service.yaml and servicemanagement/ServiceConsumers.yaml.
• The resource is "excluded" for both yaml files because they're both handwritten
• These yaml files define "examples" that both use endpoints_iam.tf.erb

But anyway, the point is that the google_endpoints_service resource is already covered by https://github.com/hashicorp/terraform-provider-google-beta/blob/main/google-beta/services/servicemanagement/resource_endpoints_service_test.go, and there isn't a real ServiceConsumers resource to be tested, so no tests are missing. The spurious failures caused by generating these tests are a problem for changing test generation, but not an issue on their own.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.