Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bigtable app profile resource #2113

Merged
merged 7 commits into from
Aug 16, 2019
Merged

Add bigtable app profile resource #2113

merged 7 commits into from
Aug 16, 2019

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jul 29, 2019

add resource google_bigtable_app_profile

Release Note for Downstream PRs (will be copied)

`google_bigtable_app_profile` is now available.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 672fee128da24a20afac40c086b616d916062445.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#988
depends: GoogleCloudPlatform/terraform-google-conversion#138
depends: hashicorp/terraform-provider-google#4126

@megan07 megan07 requested a review from rileykarson July 29, 2019 15:28
@megan07 megan07 requested a review from tysen August 8, 2019 22:11
tysen
tysen reviewed Aug 12, 2019
View reviewed changes
products/bigtable/api.yaml Outdated Show resolved Hide resolved
third_party/terraform/tests/resource_bigtable_app_profile_test.go Outdated Show resolved Hide resolved
templates/terraform/decoders/app_profile.erb Outdated
res["multiClusterRoutingUseAny"] = true
}

if _, ok := res["name"]; ok {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this pattern in a few places now. I think we should have a util function like getImportIdQualifiers but a little more general that extracts components of a name (or another) field into a map.

products/bigtable/api.yaml Show resolved Hide resolved
products/bigtable/api.yaml Outdated Show resolved Hide resolved
products/bigtable/api.yaml Outdated Show resolved Hide resolved
templates/terraform/encoders/app_profile.erb Outdated Show resolved Hide resolved
templates/terraform/decoders/app_profile.erb Outdated Show resolved Hide resolved
templates/terraform/encoders/app_profile.erb Outdated Show resolved Hide resolved
@rileykarson
Copy link
Member

Oops- sorry about missing this before. Leaving review to @tysen.

@rileykarson rileykarson removed their request for review August 12, 2019 22:06
@megan07 megan07 force-pushed the megan_bigtable_appprofile branch from 672fee1 to bf19fd2 Compare August 13, 2019 20:05
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cab14e2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, cab14e2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@megan07 megan07 requested a review from tysen August 13, 2019 20:27
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2c58df0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

tysen
tysen reviewed Aug 15, 2019
View reviewed changes
products/bigtable/api.yaml Outdated Show resolved Hide resolved
products/bigtable/api.yaml Outdated Show resolved Hide resolved
third_party/terraform/tests/resource_bigtable_app_profile_test.go Outdated Show resolved Hide resolved
templates/terraform/custom_expand/bigtable_app_profile_routing.erb Show resolved Hide resolved
@megan07 megan07 force-pushed the megan_bigtable_appprofile branch from 2c58df0 to 62d98d6 Compare August 15, 2019 20:23
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 62d98d6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@megan07 megan07 requested a review from tysen August 15, 2019 20:37
@megan07 megan07 force-pushed the megan_bigtable_appprofile branch from 62d98d6 to 7eaa3b8 Compare August 16, 2019 21:43
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7eaa3b8.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#359

@megan07 megan07 force-pushed the megan_bigtable_appprofile branch from 7eaa3b8 to 0b9e2b3 Compare August 16, 2019 22:06
@megan07 megan07 force-pushed the megan_bigtable_appprofile branch from 0b9e2b3 to 5d60643 Compare August 16, 2019 22:30
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5d60643.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#169

@modular-magician
Update tracked submodules -> HEAD on Fri Aug 16 22:50:28 UTC 2019
8f1574b 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 7d2161c into GoogleCloudPlatform:master Aug 16, 2019
@modular-magician modular-magician mentioned this pull request Aug 17, 2019
Merged
@SarahFrench SarahFrench deleted the megan_bigtable_appprofile branch March 26, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tysen tysen tysen approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@megan07 @modular-magician @rileykarson @tysen @googlebot