address review comments

GoogleCloudPlatform · Aug 16, 2019 · 0b9e2b3 · 0b9e2b3
1 parent 4e9ac7a
commit 0b9e2b3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/products/bigtable/api.yaml b/products/bigtable/api.yaml
@@ -50,7 +50,7 @@ objects:
         url_param_only: true
       - !ruby/object:Api::Type::Boolean
         name: 'ignoreWarnings'
-        description: 'If true, ignore safety checks when deleting the app profile.'
+        description: 'If true, ignore safety checks when deleting/updating the app profile.'
         default_value: false
         url_param_only: true
     properties:
@@ -61,7 +61,7 @@ objects:
       - !ruby/object:Api::Type::String
         name: 'description'
         description: |
-          Optional long form description of the use case for this app profile.
+          Long form description of the use case for this app profile.
       - !ruby/object:Api::Type::Boolean
         name: 'multiClusterRoutingUseAny'
         conflicts:

diff --git a/templates/terraform/custom_flatten/bigtable_app_profile_routing.erb b/templates/terraform/custom_flatten/bigtable_app_profile_routing.erb
@@ -13,8 +13,8 @@
 	# limitations under the License.
 -%>
 func flatten<%= prefix -%><%= titlelize_property(property) -%>(v interface{}, d *schema.ResourceData) interface{} {
-    if v == nil {
-	    return false
+	if v == nil {
+		return false
 	}
 
 	return true

diff --git a/third_party/terraform/tests/resource_bigtable_app_profile_test.go b/third_party/terraform/tests/resource_bigtable_app_profile_test.go
@@ -8,7 +8,7 @@ import (
 	"github.com/hashicorp/terraform/helper/resource"
 )
 
-func TestAccBigtableAppProfile_basic(t *testing.T) {
+func TestAccBigtableAppProfile_update(t *testing.T) {
 	t.Parallel()
 
 	instanceName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))