ML Engine Models in Terraform #2071

rambleraptor · 2019-07-17T23:01:11Z

My first Terraform resource!

I ran the lone acceptance test (no updates on this resource) and it passed!

Please tear this resource apart.

Referencing: https://github.com/GoogleCloudPlatform/magic-modules/issues/2061

Release Note for Downstream PRs (will be copied)

modular-magician · 2019-07-17T23:13:20Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of b581159.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#957
depends: GoogleCloudPlatform/terraform-google-conversion#128
depends: hashicorp/terraform-provider-google#4053
depends: modular-magician/ansible#316

modular-magician · 2019-07-18T17:30:10Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 795f6c8.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

Can you add a link to the docs in third_party/terraform/website-compiled/google.erb?

Also ref: hashicorp/terraform-provider-google#3038 (I guess it doesn't fix it outright because it doesn't do IAM, though now we have the ability to generate those for TF so it should be a really easy followup)

third_party/terraform/utils/config.go.erb

products/mlengine/terraform.yaml

templates/terraform/examples/ml_model_basic.tf.erb

rambleraptor · 2019-07-23T22:43:34Z

Comments have been addressed! But, the tests do not pass. This is because the vars Hash in examples injects in dashes, which the ML Engine API does not accept.

I'm making a separate PR with a change because it's gonna touch all the files.

modular-magician · 2019-07-23T22:56:35Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d511706.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rambleraptor · 2019-07-24T17:25:59Z

@danawillow please take a look! With the dash-removing PR, the ML generated tests (full + basic) both pass!

modular-magician · 2019-07-24T17:38:30Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a930e37.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

almost there!

third_party/terraform/website-compiled/google.erb

modular-magician · 2019-08-05T20:00:07Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 85d36bb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

third_party/terraform/utils/provider.go.erb

modular-magician · 2019-08-08T19:51:25Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9bd2cb0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rambleraptor · 2019-08-16T22:14:28Z

I completely forgot about this PR (thanks email filters!). Made those changes + it's running through the Magician now.

modular-magician · 2019-08-16T22:25:46Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, af3324d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

Looks good, merging TF PRs now, will leave the rest for you

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Jul 17, 2019

modular-magician added downstream-generated ansible terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Jul 17, 2019

rambleraptor requested a review from danawillow July 17, 2019 23:14

danawillow suggested changes Jul 19, 2019

View reviewed changes

rambleraptor force-pushed the ml-engine branch from 795f6c8 to d511706 Compare July 23, 2019 22:42

rambleraptor mentioned this pull request Jul 23, 2019

[terraform] removing dash in random suffix for examples #2090

Merged

rambleraptor mentioned this pull request Jul 24, 2019

Support Cloud ML Engine hashicorp/terraform-provider-google#3038

Closed

rambleraptor force-pushed the ml-engine branch from d511706 to a930e37 Compare July 24, 2019 17:25

danawillow reviewed Jul 25, 2019

View reviewed changes

third_party/terraform/website-compiled/google.erb Show resolved Hide resolved

third_party/terraform/website-compiled/google.erb Show resolved Hide resolved

danawillow reviewed Aug 5, 2019

View reviewed changes

third_party/terraform/utils/provider.go.erb Outdated Show resolved Hide resolved

rambleraptor force-pushed the ml-engine branch from 85d36bb to 9bd2cb0 Compare August 8, 2019 19:39

danawillow approved these changes Aug 16, 2019

View reviewed changes

modular-magician added the automerged label Aug 19, 2019

rambleraptor added 3 commits August 19, 2019 10:19

getting close to model

80d1501

it works!

af613a1

test fi

fe8d9ab

rambleraptor added 3 commits August 19, 2019 10:20

PR comments

7cb39a2

PR comments addressed

27e8f8d

why did that line go away

693c872

rambleraptor force-pushed the ml-engine branch from af3324d to 8b7651a Compare August 19, 2019 17:22

rebase issue

f808855

rambleraptor force-pushed the ml-engine branch 2 times, most recently from f808855 to 39c4b44 Compare August 19, 2019 17:37

Update tracked submodules -> HEAD on Mon Aug 19 17:39:15 UTC 2019

295f5bd

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the ml-engine branch from 39c4b44 to 295f5bd Compare August 19, 2019 17:39

modular-magician merged commit f9218cc into master Aug 19, 2019

modular-magician mentioned this pull request Aug 20, 2019

Bug fixes for GCP (as of 2019-08-19T06:07:37+00:00) ansible/ansible#60920

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ML Engine Models in Terraform #2071

ML Engine Models in Terraform #2071

rambleraptor commented Jul 17, 2019 •

edited

Loading

modular-magician commented Jul 17, 2019

modular-magician commented Jul 18, 2019

danawillow left a comment

rambleraptor commented Jul 23, 2019

modular-magician commented Jul 23, 2019

rambleraptor commented Jul 24, 2019

modular-magician commented Jul 24, 2019

danawillow left a comment

modular-magician commented Aug 5, 2019

modular-magician commented Aug 8, 2019

rambleraptor commented Aug 16, 2019

modular-magician commented Aug 16, 2019

danawillow left a comment

ML Engine Models in Terraform #2071

ML Engine Models in Terraform #2071

Conversation

rambleraptor commented Jul 17, 2019 • edited Loading

Release Note for Downstream PRs (will be copied)

modular-magician commented Jul 17, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 18, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

rambleraptor commented Jul 23, 2019

modular-magician commented Jul 23, 2019

Pull request statuses

New Pull Requests

rambleraptor commented Jul 24, 2019

modular-magician commented Jul 24, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 5, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 8, 2019

Pull request statuses

New Pull Requests

rambleraptor commented Aug 16, 2019

modular-magician commented Aug 16, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

rambleraptor commented Jul 17, 2019 •

edited

Loading