PR comments addressed

GoogleCloudPlatform · Jul 24, 2019 · a930e37 · a930e37
1 parent cc52642
commit a930e37
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/products/mlengine/terraform.yaml b/products/mlengine/terraform.yaml
@@ -19,9 +19,13 @@ overrides: !ruby/object:Overrides::ResourceOverrides
       - !ruby/object:Provider::Terraform::Examples
         name: "ml_model_basic"
         primary_resource_id: "default"
+        vars:
+          model_name: 'default'
       - !ruby/object:Provider::Terraform::Examples
         name: "ml_model_full"
         primary_resource_id: "default"
+        vars:
+          model_name: 'default'
     properties:
       name: !ruby/object:Overrides::Terraform::PropertyOverride
         custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.erb'

diff --git a/templates/terraform/examples/ml_model_basic.tf.erb b/templates/terraform/examples/ml_model_basic.tf.erb
@@ -1,5 +1,5 @@
-resource "google_ml_engine_model" <%= ctx[:primary_resource_id] -%> {
-  name = <%= ctx[:primary_resource_id] %>
+resource "google_ml_engine_model" "<%= ctx[:primary_resource_id] -%>" {
+  name = "<%= ctx[:vars]['model_name'] -%>"
   description = "My model"
   regions = ["us-central1"]
 }
diff --git a/templates/terraform/examples/ml_model_full.tf.erb b/templates/terraform/examples/ml_model_full.tf.erb
@@ -1,5 +1,5 @@
-resource "google_ml_engine_model" <%= ctx[:primary_resource_id] -%> {
-  name = <%= ctx[:primary_resource_id] %>
+resource "google_ml_engine_model" "<%= ctx[:primary_resource_id] -%>" {
+  name = "<%= ctx[:vars]['model_name'] -%>"
   description = "My model"
   regions = ["us-central1"]
   labels  = {