Turn go mod vendor back on in the Magician

[rileykarson]

This doesn't run when there are changes, so let's re-enable it for everything.

Reverses #1428

/cc @rambleraptor

---

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

[rambleraptor]

How long has this issue been happening?

[rileykarson]

Presumably since that change, #1597 is the first one we noticed I think. We've held most vendor changes because 0.12 is thrashing them all.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 2be3c5f.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#42

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3d9101b.

Pull request statuses

No diff detected in terraform-provider-google-beta.
terraform-google-conversion already has an open PR.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[chrisst]

@rambleraptor and I were just talking. Another issues that neither of these command will catch brand new files (unstaged changes). Given that most vendoring is needed when whole new hand written resources are added it will miss more needed vendor changes than catch.

I think our options are:

• If it's fast enough, run go mod vendor for every change (your first proposal)
• Check for unstaged + modified (if [[ -z git status -s ]])

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5ce2545.

Pull request statuses

No diff detected in terraform-provider-google-beta.
terraform-google-conversion already has an open PR.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 86746ba.

Pull request statuses

No diff detected in terraform-provider-google-beta.
terraform-google-conversion already has an open PR.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[rileykarson]

So, ideally we wouldn't see any changes but I think what's happening is that MM hasn't picked up on the patch for signed url key in the mapper repo: https://sunrisecafe.ci.cloud-graphite.com/teams/magic-modules/pipelines/magician/jobs/mm-generate/builds/2451#L5c8852bd:237

[chrisst]

The changes look fine in the validator because I think vendor wasn't running at all before, so it's removing unused dependencies.

[rileykarson]

Right! The changes are correct, but we don't expect them to be made because there's no changes in Terraform, so that means our skipping functionality isn't working. But I don't think that's true, and that it does work correctly- I think this is a result of how our patch handling works, and that we'll have false positives from time to time.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, aeea057.

Pull request statuses

No diff detected in terraform-provider-google-beta.
terraform-google-conversion already has an open PR.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[chrisst]

Makes sense.