Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run go mod vendor if git differences #1428

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

rambleraptor
Copy link
Contributor

go mod vendor is an expensive operation that sometimes crashes due to intermittent network issues.

If there's no difference in the commit, it doesn't look like there's any reason that go mod vendor should be run.


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@rambleraptor
Copy link
Contributor Author

From the Concourse run:

Old mm-generate run-time: ~7m
New mm-generate run-time (when no TF changes detected): 5m40s

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of e44725a.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@rambleraptor
Copy link
Contributor Author

@ndmckinley - Magician code review
@SirGitsalot - just for your context.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice. Thank you, great call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants