Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't request reviews on closed pull_requests #12524

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Don't request reviews on closed pull_requests #12524

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71813c4
don't request reviews on closed pull_requests
ScottSuarez Dec 9, 2024
fa14e00
simplify logic
ScottSuarez Dec 9, 2024
142e1cb
invert logic and only run if open
ScottSuarez Dec 9, 2024
bbd2d8f
Update .github/workflows/request-reviewer.yml
ScottSuarez Dec 9, 2024
a396c4d
safely access state based on action
ScottSuarez Dec 9, 2024
22b0387
Merge branch 'no-review-request-closed' of https://github.com/ScottSu…
ScottSuarez Dec 9, 2024
290a71f
Update .github/workflows/request-reviewer.yml
ScottSuarez Dec 9, 2024
458f025
Update .github/workflows/request-reviewer.yml
ScottSuarez Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/request-reviewer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:

jobs:
request-review:
if: (github.event.action == 'created' && github.event.issue.state == 'open' && github.event.issue.draft == false && github.event.comment.user.login == github.event.issue.user.login) || (github.event.action != 'created' && github.event.pull_request.state == 'open' && github.event.pull_request.draft == false )
if: (github.event.issue.state == 'open' && github.event.issue.draft == false) && (github.event.action != 'created' || github.event.comment.user.login == github.event.issue.user.login)
ScottSuarez marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
permissions:
pull-requests: write
Expand Down
Loading