Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't request reviews on closed pull_requests #12524

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Don't request reviews on closed pull_requests #12524

merged 8 commits into from
Dec 9, 2024

Conversation

ScottSuarez
Copy link
Contributor

closes hashicorp/terraform-provider-google#20129

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@ScottSuarez ScottSuarez closed this Dec 9, 2024
@ScottSuarez ScottSuarez reopened this Dec 9, 2024
@ScottSuarez ScottSuarez closed this Dec 9, 2024
@ScottSuarez ScottSuarez reopened this Dec 9, 2024
@ScottSuarez ScottSuarez requested a review from melinath December 9, 2024 18:43
@ScottSuarez
Copy link
Contributor Author

unfortunately I can't test this in PR since it's a pull_request_target job

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez @melinath
Update .github/workflows/request-reviewer.yml
290a71f 
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
melinath
melinath requested changes Dec 9, 2024
View reviewed changes
.github/workflows/request-reviewer.yml Outdated Show resolved Hide resolved
@ScottSuarez @melinath
Update .github/workflows/request-reviewer.yml
458f025 
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@ScottSuarez ScottSuarez requested a review from melinath December 9, 2024 19:22
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez merged commit 673112a into GoogleCloudPlatform:main Dec 9, 2024
11 checks passed
This was referenced Dec 9, 2024
Merged
Merged
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
@ScottSuarez @melinath @amanMahendroo
Don't request reviews on closed pull_requests (GoogleCloudPlatform#12524
b5d2aa3 
)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make review request GHA not activate on closed issues
3 participants
@ScottSuarez @modular-magician @melinath