-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add google_oracle_database_cloud_exadata_infrastructure datasource #11996
Feat: Add google_oracle_database_cloud_exadata_infrastructure datasource #11996
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 6 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
return fmt.Sprintf(` | ||
data "google_oracle_database_cloud_exadata_infrastructure" "my-exadata"{ | ||
cloud_exadata_infrastructure_id = "ofake-do-not-delete-tf-exadata" | ||
project = "oci-terraform-testing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to hard code this project here. There should be functions used in the other tests to pass through this project via environment variables. Can you use those in this test? You'll need to call them from the above function and pass the value through as an argument to this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other resources were autogen, we override the documentation example later with our project. #11961
Part of- hashicorp/terraform-provider-google#19849
Release Note Template for Downstream PRs (will be copied)